You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/12/01 18:34:35 UTC
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8716
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Impala integration doc: clarify partitioning recommendations
Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Reviewed-on: http://gerrit.cloudera.org:8080/8714
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Dan Burkert <da...@apache.org>
(cherry picked from commit 946004aeed4ce2844c2cd14bbf2077b419de3c49)
---
M docs/kudu_impala_integration.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/8716/1
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc@504
PS1, Line 504: - For small tables, such as dimension tables, ensure that each tablet is at
> No, it's to avoid excessive hash partitioning when it's unnecessary. If th
I think it could be better phrased noting that this recommendation is for hash partitioning:
When hash partitioning smaller tables, such as dimension tables, ensure that each partition is at least 1 GB in size.
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Dec 2017 21:03:45 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2) to the change originally created by Dan Burkert. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Impala integration doc: clarify partitioning recommendations
Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Reviewed-on: http://gerrit.cloudera.org:8080/8714
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/kudu_impala_integration.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/8716/2
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Impala integration doc: clarify partitioning recommendations
Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Reviewed-on: http://gerrit.cloudera.org:8080/8714
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Dan Burkert <da...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/8716
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M docs/kudu_impala_integration.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:25:34 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc@504
PS1, Line 504: - For small tables, such as dimension tables, ensure that each tablet is at
the idea here is to avoid excessive normalization? i can think of a lot of schemas with tables much smaller than this, such as a list of US states.
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Dec 2017 20:00:44 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.6.x) Impala integration doc: clarify partitioning recommendations
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8716 )
Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/8716/1/docs/kudu_impala_integration.adoc@504
PS1, Line 504: - For small tables, such as dimension tables, ensure that each tablet is at
> the idea here is to avoid excessive normalization? i can think of a lot of
No, it's to avoid excessive hash partitioning when it's unnecessary. If the table is < 1 GB total, then it should just be a single (small) tablet. Perhaps there's a better way to phrase that?
--
To view, visit http://gerrit.cloudera.org:8080/8716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8716
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 01 Dec 2017 20:40:22 +0000
Gerrit-HasComments: Yes