You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/17 12:50:09 UTC

[GitHub] [hbase] YutSean edited a comment on pull request #3940: HBASE-26566 Optimize encodeNumeric in OrderedBytes

YutSean edited a comment on pull request #3940:
URL: https://github.com/apache/hbase/pull/3940#issuecomment-996697798


   @Reidddddd After checking the current UT and some configurations. I found that, although the method encodes BigDecimal, but current MAX_PRECISION is really limited (31). It can only fit the domain of Long. I added some test case beyond this domain. The old implementation will also fail. The new change just follows the old logic. If we do not need to fit some really big decimal, we do not need new UT I think. But if we need to fix them, the function logic should be reconstructed and added more large decimal cases in UTs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org