You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Tracy Snell (JIRA)" <ji...@apache.org> on 2010/10/15 13:38:40 UTC
[jira] Created: (CAMEL-3236) Camel JMX Component
Camel JMX Component
-------------------
Key: CAMEL-3236
URL: https://issues.apache.org/activemq/browse/CAMEL-3236
Project: Apache Camel
Issue Type: New Feature
Reporter: Tracy Snell
Priority: Minor
Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63082#action_63082 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Added osgi feature: 1031466.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63111#action_63111 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Thanks for the patch. We are getting closer
{code}
-------------------------------------------------------------------------------
Test set: org.apache.camel.component.jmx.JMXRemoteTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.79 sec <<< FAILURE!
notification(org.apache.camel.component.jmx.JMXRemoteTest) Time elapsed: 0.776 sec <<< FAILURE!
java.lang.AssertionError: junit.framework.AssertionFailedError: org.custommonkey.xmlunit.Diff
[different] Expected text value '2010-01-07T10:30:15.000-05:00' but was '2010-01-07T16:30:15.000+01:00' - comparing <dateTime ...>2010-01-07T10:30:15.000-05:00</dateTime> at /NotificationEvent[1]/dateTime[1]/text()[1] to <dateTime ...>2010-01-07T16:30:15.000+01:00</dateTime> at /NotificationEvent[1]/dateTime[1]/text()[1]
at junit.framework.Assert.fail(Assert.java:47)
{code}
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63081#action_63081 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Thanks Mark for the donation to Apache.
trunk: 1031461.
I had to disable a couple of tests with @Ignore. They fail due some XML timestamp comparison. Please take a look if you got the time.
eg check out the source from Apache Camel and see if you can fix it and supply a patch.
{code}
<?xml version="1.0" encoding="UTF-8"?><NotificationEvent xmlns="urn:org.apache.camel.component:jmx"><source>TestDomain:name=simpleBean</source><message>I was touched</message><sequence>0</sequence><timestamp>1262856615000</timestamp><dateTime>2010-01-07T10:30:15.000+01:00</dateTime><type>touched</type></NotificationEvent>Nov 5, 2010 8:42:32 AM ClientCommunicatorAdmin restart
java.lang.AssertionError: junit.framework.AssertionFailedError: org.custommonkey.xmlunit.Diff
[different] Expected text value '1262878215000' but was '1262856615000' - comparing <timestamp ...>1262878215000</timestamp> at /NotificationEvent[1]/timestamp[1]/text()[1] to <timestamp ...>1262856615000</timestamp> at /NotificationEvent[1]/timestamp[1]/text()[1]
at junit.framework.Assert.fail(Assert.java:47)
at org.custommonkey.xmlunit.XMLAssert.assertXMLEqual(XMLAssert.java:125)
at org.custommonkey.xmlunit.XMLAssert.assertXMLEqual(XMLAssert.java:113)
at org.apache.camel.component.jmx.XmlFixture.assertXMLIgnorePrefix(XmlFixture.java:76)
at org.apache.camel.component.jmx.SimpleBeanFixture.assertMessageReceived(SimpleBeanFixture.java:255)
at org.apache.camel.component.jmx.JMXRemoteTest.notification(JMXRemoteTest.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
{code}
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3236:
-------------------------------
Fix Version/s: 2.6.0
Thanks for donating this to Apache. We will work on getting this into the next release, e.g. Camel 2.6.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63112#action_63112 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Failed tests:
attributeChange(org.apache.camel.component.jmx.JMXConsumerTest)
notification(org.apache.camel.component.jmx.JMXConsumerTest)
userData(org.apache.camel.component.jmx.JMXConsumerTest)
jmxConnection(org.apache.camel.component.jmx.JMXConsumerTest)
mbeanServerNotification(org.apache.camel.component.jmx.JMXConsumerTest)
relationNotification(org.apache.camel.component.jmx.JMXConsumerTest)
timerNotification(org.apache.camel.component.jmx.JMXConsumerTest)
notification(org.apache.camel.component.jmx.JMXRemoteTest)
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63142#action_63142 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
I got this compilation error on JDK 1.5
{code}
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
/Users/davsclaus/workspace/camel/components/camel-jmx/src/test/java/org/apache/camel/component/jmx/beans/SimpleBeanMBean.java:[57,0] 'class' or 'interface' expected
/Users/davsclaus/workspace/camel/components/camel-jmx/src/test/java/org/apache/camel/component/jmx/beans/SimpleBeanMBean.java:[59,0] 'class' or 'interface' expected
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12 seconds
[INFO] Finished at: Sat Nov 06 19:38:39 CET 2010
[INFO] Final Memory: 24M/44M
[INFO] ------------------------------------------------------------------------
davsclaus:(svn)camel[trunk:1032127]/components/camel-jmx$ java -version
java version "1.5.0_24"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_24-b02-357-10M3065)
Java HotSpot(TM) Client VM (build 1.5.0_24-149, mixed mode, sharing)
{code}
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-attempt3.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63127#action_63127 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Mark maybe its possible to set maven to only compile and test if JDK 1.6 or better.
That way you can keep the test source code as is.
Camel 3.0 will be JDK 1.6+
But we will keep Camel 2.x compatible with JDK 1.5.
Yeah the timezone testing is a bugger. Maybe you can just test by the date, eg YYYY-mm-DD.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63129#action_63129 ]
Mark Ford commented on CAMEL-3236:
----------------------------------
I have other tests where I'm stripping the timestamp/datetime before doing the assertion. I'll use that same technique for these tests.
I'll look at the JDK 1.5 shortly.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Ford updated CAMEL-3236:
-----------------------------
Attachment: camel-jmx-patch.txt
I have repackaged the code from my google code project so it matches the conventions of the other components. The build works and the included unit tests put the coverage up around 90%.
The code is commented with Javadoc and some inline comments. Additional user documentation is available here:
http://code.google.com/p/camel-jmx/
Let me know if there's anything else needed to complete this donation.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Priority: Minor
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3236:
-------------------------------
Component/s: jmx
Priority: Major (was: Minor)
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63001#action_63001 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
We should prefer to use JAXB for generating the XML schema. I have created a ticket for this
http://code.google.com/p/camel-jmx/issues/detail?id=7
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3236.
--------------------------------
Resolution: Fixed
trunk: 1032130.
Mark it works now. Thanks for all the patches and donating it to Apache.
Btw just wait to we get the CI servers testing this on AIX, HP-UX and other eccentric platforms. Then we may get other weird test errors :)
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-attempt3.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-3236:
----------------------------------
Assignee: Claus Ibsen
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63113#action_63113 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
I wonder if the unit tests can be compatible with JDK 1.5.
When you compile with 1.5 you get this compilation error
/Users/davsclaus/workspace/camel/components/camel-jmx/src/test/java/org/apache/camel/component/jmx/SimpleBeanFixture.java:[27,24] cannot find symbol
symbol : class JMX
location: package javax.management
Its because that JMX class is only from JDK 1.6+.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Ford updated CAMEL-3236:
-----------------------------
Attachment: camel-jmx-tstamp-jdk15.txt
I fixed the timestamp by using XSLT to strip the timestamp and datetime from the xml prior to the assertion. I use xpath to validate that the timestamp and datetime elements exist but avoid the datetime format due to the timezone issue.
I added a profile to the pom.xml to add the required dependencies for jaxb when running in jdk 1.5. I also modified the unit tests to not use the JMX helper class and instead use the long way around to create the proxy.
I'm still having trouble with the relationNotification test so I added the ignore flag on that one. The notification created by the simple bean apparently isn't valid according to the rules in 1.5 although it worked fine in 1.6. I'll look at this at some point in the future.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3236:
-------------------------------
Comment: was deleted
(was: I got this compilation error on JDK 1.5
{code}
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
/Users/davsclaus/workspace/camel/components/camel-jmx/src/test/java/org/apache/camel/component/jmx/beans/SimpleBeanMBean.java:[57,0] 'class' or 'interface' expected
/Users/davsclaus/workspace/camel/components/camel-jmx/src/test/java/org/apache/camel/component/jmx/beans/SimpleBeanMBean.java:[59,0] 'class' or 'interface' expected
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12 seconds
[INFO] Finished at: Sat Nov 06 19:38:39 CET 2010
[INFO] Final Memory: 24M/44M
[INFO] ------------------------------------------------------------------------
davsclaus:(svn)camel[trunk:1032127]/components/camel-jmx$ java -version
java version "1.5.0_24"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_24-b02-357-10M3065)
Java HotSpot(TM) Client VM (build 1.5.0_24-149, mixed mode, sharing)
{code})
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-attempt3.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63140#action_63140 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
Latest patch in trunk: 1032126.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63121#action_63121 ]
Mark Ford commented on CAMEL-3236:
----------------------------------
It would be easier if you'd just move to my timezone. ;)
As for JDK 1.5, I've been developing in 1.6 since 1.5 entered its end of life phase. I'll switch back and make the changes if camel is still on 1.5. At some point, camel needs to make the switch since there are many environments where 1.5 is no longer allowed to run.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Ford updated CAMEL-3236:
-----------------------------
Attachment: camel-jmx-tstamp-attempt3.txt
Wow, three attempts to fix a timestamp issue. This is going to look bad on my permanent record.
This patch replaces the assertion on the value of the timestamp with an assertion on its existence. I also noticed that SimpleBeanMBean was not part of the update but was included in the previous patch. I am including this file again as part of this patch. I believe it is necessary when registering the test bean under jdk 1.5.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-attempt3.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-3236) Camel JMX Component
Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Ford updated CAMEL-3236:
-----------------------------
Attachment: camel-jmx-timestamp.txt
The timestamp error is likely due to the difference in our timezones. I was using a fixed datetime for the unit tests but neglecting to set the timezone in the pattern. The attached patch includes this fix.
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-3236) Camel JMX Component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63139#action_63139 ]
Claus Ibsen commented on CAMEL-3236:
------------------------------------
We are getting closer
I get some timestamp errors still
{code}
org.junit.ComparisonFailure:
Expected :1262878215000
Actual :1262856615000
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at org.apache.camel.component.jmx.SimpleBeanFixture.assertMessageReceived(SimpleBeanFixture.java:288)
at org.apache.camel.component.jmx.JMXConsumerTest.waitAndAssertMessageReceived(JMXConsumerTest.java:94)
at org.apache.camel.component.jmx.JMXConsumerTest.attributeChange(JMXConsumerTest.java:44)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
{code}
All 7 tests fail on JMXConsumerTest on both JDK 1.5 and 1.6.
And the change to pom.xml was not needed as camel-core will bring in the JAXB stuff if on JDK 1.5. I got some maven activation for that.
I will apply the patch but keep the JMXConsumerTest at @Ignore
> Camel JMX Component
> -------------------
>
> Key: CAMEL-3236
> URL: https://issues.apache.org/activemq/browse/CAMEL-3236
> Project: Apache Camel
> Issue Type: New Feature
> Components: jmx
> Reporter: Tracy Snell
> Assignee: Claus Ibsen
> Fix For: 2.6.0
>
> Attachments: camel-jmx-patch.txt, camel-jmx-timestamp.txt, camel-jmx-tstamp-jdk15.txt
>
>
> Mark Ford is donating his Camel-JMX component. Providing a Jira for the code to be submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.