You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/14 12:28:30 UTC

[GitHub] [tvm] manupa-arm commented on pull request #8274: [TIR][VM] Revert a change to lower_tvm_builtin.cc from #6126

manupa-arm commented on pull request #8274:
URL: https://github.com/apache/tvm/pull/8274#issuecomment-919102241


   @tmoreau89 @areusch @mbrookhart ,
   
   IIUC,
   
   This is problematic for micro because now the constant sized allocates are forced to be placed on stack (bypassing TVMPlatformAllocate abstraction) because that is how the codegen_c lowers the allocate.
   
   https://github.com/apache/tvm/blob/1b99adcd8f4b7bd4ad2e333da82b2204803438ee/src/target/source/codegen_c.cc#L860-L877
   
   I dont think is desired.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org