You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2017/06/05 10:52:16 UTC

[GitHub] zeppelin pull request #2250: [ZEPPELIN-2085] Interpret scala code in paste m...

GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/2250

    [ZEPPELIN-2085] Interpret scala code in paste mode

    ### What is this PR for?
    Don't split scala code to lines.
    
    Interpreter code becomes more and more complicated because some lines have to be executed
    together (companion objects, etc.). And still it doesn't handle all possibilities.
    
    I propose not to split interpreter input at all.
    I checked scala repl sources: repl paste mode interpret code without splitting.
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2085
    
    ### How should this be tested?
    Try to run several code snippets attached to jira issue.
    See also https://issues.apache.org/jira/browse/ZEPPELIN-658
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-2085

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2250
    
----
commit 4087cfe2b17fa0327c5a73d51aad44ce1e74776b
Author: Igor Drozdov <ig...@epam.com>
Date:   2017-03-20T14:16:22Z

    Interpret scala code as a single piece

commit 71d8eabf5811d1a6186dbdf6710536d245af4d88
Author: Igor Drozdov <ig...@epam.com>
Date:   2017-05-18T08:13:57Z

    Companion object definition test

commit c7e5c58d333bea498fdd9edfbe7548efd75458b3
Author: Igor Drozdov <ig...@epam.com>
Date:   2017-05-22T13:07:46Z

    fixup Interpret scala code as a single piece

commit 12b3d3303865da426e9759cffa90a27bef346eac
Author: Igor Drozdov <ig...@epam.com>
Date:   2017-06-05T09:05:01Z

    Don't use hamrest in tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---