[shardingsphere] branch master updated: Fix sonar issues of ResultCode (#25712)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 8acf3ef1e39 Fix sonar issues of ResultCode (#25712)
8acf3ef1e39 is described below

commit 8acf3ef1e398441b4cc5ef23a6c6b6c6b3a8b677
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Tue May 16 22:44:09 2023 +0800

    Fix sonar issues of ResultCode (#25712)
---
 .../project/controller/AbstractRestController.java |  4 ++--
 .../agent/jdbc/project/vo/response/HttpResult.java | 24 ++++++----------------
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/controller/AbstractRestController.java b/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/controller/AbstractRestController.java
index 988c0c1333f..5a2751265e7 100644
--- a/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/controller/AbstractRestController.java
+++ b/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/controller/AbstractRestController.java
@@ -26,10 +26,10 @@ import org.apache.shardingsphere.test.e2e.agent.jdbc.project.vo.response.ResultC
 public abstract class AbstractRestController {
     
     protected HttpResult<Void> success() {
-        return new HttpResult<Void>().toBuilder().code(ResultCode.SUCCESS.getCode()).message(ResultCode.SUCCESS.getMessage()).build();
+        return new HttpResult<>(ResultCode.SUCCESS.getCode(), ResultCode.SUCCESS.getMessage(), null);
     }
     
     protected <T> HttpResult<T> success(final T data) {
-        return new HttpResult<T>().toBuilder().code(ResultCode.SUCCESS.getCode()).message(ResultCode.SUCCESS.getMessage()).data(data).build();
+        return new HttpResult<>(ResultCode.SUCCESS.getCode(), ResultCode.SUCCESS.getMessage(), data);
     }
 }
diff --git a/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/vo/response/HttpResult.java b/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/vo/response/HttpResult.java
index 5f094d1a3eb..84a7c8ac952 100644
--- a/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/vo/response/HttpResult.java
+++ b/test/e2e/agent/jdbc-project/src/main/java/org/apache/shardingsphere/test/e2e/agent/jdbc/project/vo/response/HttpResult.java
@@ -17,33 +17,21 @@
 
 package org.apache.shardingsphere.test.e2e.agent.jdbc.project.vo.response;
 
-import lombok.Builder;
 import lombok.Getter;
-import lombok.NoArgsConstructor;
-
-import java.io.Serializable;
+import lombok.RequiredArgsConstructor;
 
 /**
  * Http result.
  * 
  * @param <T> type of data
  */
-@NoArgsConstructor
+@RequiredArgsConstructor
 @Getter
-public class HttpResult<T> implements Serializable {
-    
-    private static final long serialVersionUID = -7263644459975356117L;
-    
-    private int code;
+public class HttpResult<T> {
     
-    private String message;
+    private final int code;
     
-    private T data;
+    private final String message;
     
-    @Builder(toBuilder = true)
-    public HttpResult(final int code, final String message, final T data) {
-        this.code = code;
-        this.message = message;
-        this.data = data;
-    }
+    private final T data;
 }