You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2023/04/03 17:04:15 UTC
[GitHub] [camel] dk2k opened a new pull request, #9797: static methods don't need final keyword, it's senseless
dk2k opened a new pull request, #9797:
URL: https://github.com/apache/camel/pull/9797
static methods don't need final keyword, it's senseless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9797: static methods don't need final keyword, it's senseless
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9797:
URL: https://github.com/apache/camel/pull/9797#issuecomment-1494678920
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #9797: static methods don't need final keyword, it's senseless
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #9797:
URL: https://github.com/apache/camel/pull/9797#discussion_r1156236716
##########
components/camel-sql/src/generated/java/org/apache/camel/component/sql/stored/template/generated/TokenMgrError.java:
##########
@@ -47,7 +47,7 @@ public class TokenMgrError extends Error
* Replaces unprintable characters by their escaped (or unicode escaped)
* equivalents in the given string
*/
- protected static final String addEscapes(String str) {
+ protected static String addEscapes(String str) {
Review Comment:
This class is generated so I'm afraid that this change won't have any effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] dk2k commented on pull request #9797: static methods don't need final keyword, it's senseless
Posted by "dk2k (via GitHub)" <gi...@apache.org>.
dk2k commented on PR #9797:
URL: https://github.com/apache/camel/pull/9797#issuecomment-1496304930
the topic seems to be controversial. I'm OK with keeping this PR unmerged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9797: static methods don't need final keyword, it's senseless
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9797:
URL: https://github.com/apache/camel/pull/9797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9797: static methods don't need final keyword, it's senseless
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9797:
URL: https://github.com/apache/camel/pull/9797#issuecomment-1494700500
BTW, maybe it is not really applicable here, but telling that it is meanless, it is not completely true, please read this https://stackoverflow.com/a/1743748/1997376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9797: static methods don't need final keyword, it's senseless
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9797:
URL: https://github.com/apache/camel/pull/9797#issuecomment-1494693698
Please also use a different commit message, for something more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9797: static methods don't need final keyword, it's senseless
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9797:
URL: https://github.com/apache/camel/pull/9797#issuecomment-1496428876
merging anyway as generated class will re-gen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org