[jira] [Commented] (REEF-546) Remove APIs deprecated since 0.11 from Tang and EnvironmentUtils

["Mariia Mykhailova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652819#comment-14652819 ] 

Mariia Mykhailova commented on REEF-546:
----------------------------------------

{{addAll}} looks like it needs to be moved to Tang (probably as a method of {{ConfigurationModule}}?
) instead of simply deleted (https://github.com/Microsoft-CISL/TANG/issues/164 intended to do the move but never did).

{{addClasspath}} deprecation message just says it's unsafe to use in the future but doesn't suggest alternative. Do we want just to remove the method while keeping the logic it implemented unchanged in our code? (It's used in JobClient.java and in reef-examples) Or should it be part of some larger logic change?

[~markus.weimer], could you please comment on this?

> Remove APIs deprecated since 0.11 from Tang and EnvironmentUtils
> ----------------------------------------------------------------
>
>                 Key: REEF-546
>                 URL: https://issues.apache.org/jira/browse/REEF-546
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Tang
>            Reporter: Brian Cho
>             Fix For: 0.12
>
>
> Tang seems to be the worst offender in continuing to use "deprecated" methods and classes. We need to figure out which ones are truly unneeded, and which ones we should upgrade to non-deprecated status.
> A grepped list of deprecated parts:
> {noformat}
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java:159:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java-160-  Iterable<Entry<NamedParameterNode<Set<?>>, Object>> getBoundSets();
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java-161-
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:45:@Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-46-public class ConfigurationFile {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-47-
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:54:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-55-  public static void writeConfigurationFile(
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-56-      final Configuration conf, final File confFile) throws IOException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:65:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-66-  public static void addConfiguration(final ConfigurationBuilder conf,
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-67-                                      final File tmpConfFile) throws IOException, BindException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:84:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-85-  public static void addConfiguration(final ConfigurationBuilder conf,
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-86-                                      final String contents) throws BindException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:184:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-185-  public static String toConfigurationString(final Configuration c) {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-186-    StringBuilder sb = new StringBuilder();
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:197:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-198-  static List<String> toConfigurationStringList(final Configuration c) {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-199-    ConfigurationImpl conf = (ConfigurationImpl) c;
> --
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)