You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/09 08:27:26 UTC
[GitHub] [druid] clintropolis opened a new pull request #12323: improve FileWriteOutBytes.readFully
clintropolis opened a new pull request #12323:
URL: https://github.com/apache/druid/pull/12323
### Description
Improves the performance of `FileWriteOutBytes.readFully` by using the tracked byte size added in #9722, instead of calling the channel size() method, which ends up in a native syscall to check the size of the file on disk. This `readFully` method is used by `GenericIndexedWriter.get` which is currently only used when merging spatial indexes, but would be an improvement for anything looking to read stuff out of the channel.
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #12323: improve FileWriteOutBytes.readFully
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #12323:
URL: https://github.com/apache/druid/pull/12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org