You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/03 15:34:24 UTC
[jira] [Commented] (FLINK-933) Add an input format to read
primitive types directly (not through tuples)
[ https://issues.apache.org/jira/browse/FLINK-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051438#comment-14051438 ]
ASF GitHub Bot commented on FLINK-933:
--------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/47#issuecomment-47929777
This is almost good to merge. Just a last note regarding the name of the read method `readPrimitiveSequence(String filePath, char delimiter, Class<X> typeClass)`.
I think this should definitely have a `*File` suffix like the other file based read methods
The question is now whether we should have
1. `readIntegerFile`, `readDoubleFile`, which blows up the ExecutionEnvironment code -or-
2. stick to something like `readPrimitiveFile`?
I vote for 1.
I will merge it after some further feedback regarding the name.
> Add an input format to read primitive types directly (not through tuples)
> -------------------------------------------------------------------------
>
> Key: FLINK-933
> URL: https://issues.apache.org/jira/browse/FLINK-933
> Project: Flink
> Issue Type: Bug
> Reporter: Stephan Ewen
> Assignee: Mingliang Qi
> Priority: Minor
> Labels: easyfix, features, starter
>
> Right now, reading primitive types goes either through custom formats (work intensive), or through CSV inputs. The latter return tuples.
> To read a sequence of primitives, you need to go though Tuple1, which is clumsy.
> I would suggest to add an input format to read primitive types line wise (or otherwise delimited), and also add a method to the environment for that.
--
This message was sent by Atlassian JIRA
(v6.2#6252)