You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by krish i <kr...@gmail.com> on 2016/03/03 17:27:22 UTC
Review Request 44341: Updating documentation Update
configuration-reference.md documentation on supporting private docker
registry.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Updating documentation Update configuration-reference.md documentation on supporting private docker registry.
Diffs
-----
docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4
Diff: https://reviews.apache.org/r/44341/diff/
Testing
-------
Thanks,
krish i
Re: Review Request 44341: Updating documentation Update
configuration-reference.md documentation on supporting private docker
registry.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/#review121875
-----------------------------------------------------------
Master (8f98e6e) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f02f2565550>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7f02f2565f50>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 660 passed, 5 skipped, 1 warnings in 336.71 seconds [0m
FAILURE
16:47:38 06:34 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2016, 4:27 p.m., krish i wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44341/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 4:27 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Updating documentation Update configuration-reference.md documentation on supporting private docker registry.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4
>
> Diff: https://reviews.apache.org/r/44341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> krish i
>
>
Re: Review Request 44341: Updating documentation Update
configuration-reference.md documentation on supporting private docker
registry.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44341/#review121873
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 3, 2016, 8:27 a.m., krish i wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44341/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 8:27 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Updating documentation Update configuration-reference.md documentation on supporting private docker registry.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md 3f023d77e1f8a1cc13abeaba9a4b69879f42bba4
>
> Diff: https://reviews.apache.org/r/44341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> krish i
>
>