You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/05/31 11:08:13 UTC

[GitHub] [servicecomb-service-center] zenlint commented on a change in pull request #549: Switch storage to etcd and add mock storage to tests

zenlint commented on a change in pull request #549:  Switch storage to etcd and add mock storage to tests
URL: https://github.com/apache/servicecomb-service-center/pull/549#discussion_r289347816
 
 

 ##########
 File path: syncer/test/sotrage/storage.go
 ##########
 @@ -18,24 +18,19 @@
 package storage
 
 Review comment:
   Actually, we should move folder of mock tests into syncer/pkg/mocks, include sycner/test/dcmock and syncer/test/servicecenter.
   I am going to do this.
   So please mv syncer/test/storage to syncer/pkg/mocks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services