You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2022/11/23 12:54:42 UTC
[hbase] branch branch-2.4 updated (acc4d13e7f7 -> a3ac3c581dc)
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a change to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
from acc4d13e7f7 HBASE-27464 In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size (#4881)
new 1c9f6c5ccdf HBASE-27504 Remove duplicated config 'hbase.normalizer.merge.min_region_age.days' in hbase-default.xml (#4894)
new a3ac3c581dc HBASE-27445 fix the result of DirectMemoryUtils#getDirectMemorySize (#4846)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
hbase-common/src/main/resources/hbase-default.xml | 5 ---
.../hadoop/hbase/util/DirectMemoryUtils.java | 36 +++-------------------
2 files changed, 4 insertions(+), 37 deletions(-)
[hbase] 02/02: HBASE-27445 fix the result of DirectMemoryUtils#getDirectMemorySize (#4846)
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit a3ac3c581dc9c18b5a15bcccf31794d5c1161312
Author: Ruanhui <32...@users.noreply.github.com>
AuthorDate: Wed Nov 23 20:09:41 2022 +0800
HBASE-27445 fix the result of DirectMemoryUtils#getDirectMemorySize (#4846)
Co-authored-by: huiruan <hu...@tencent.com>
Signed-off-by: Duo Zhang <zh...@apache.org>
(cherry picked from commit 2f4758ee592959ee5ddd646a6769bb81a781d610)
---
.../hadoop/hbase/util/DirectMemoryUtils.java | 36 +++-------------------
1 file changed, 4 insertions(+), 32 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
index c0a9685d13e..082796b4a15 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
@@ -18,12 +18,9 @@
package org.apache.hadoop.hbase.util;
import java.lang.management.ManagementFactory;
-import java.lang.management.RuntimeMXBean;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.nio.ByteBuffer;
-import java.util.List;
-import java.util.Locale;
import javax.management.JMException;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
@@ -37,6 +34,7 @@ import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
import org.apache.hbase.thirdparty.io.netty.buffer.ByteBufAllocatorMetric;
import org.apache.hbase.thirdparty.io.netty.buffer.ByteBufAllocatorMetricProvider;
import org.apache.hbase.thirdparty.io.netty.buffer.PooledByteBufAllocator;
+import org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent;
/**
* Utilities for interacting with and monitoring DirectByteBuffer allocations.
@@ -49,6 +47,7 @@ public class DirectMemoryUtils {
private static final MBeanServer BEAN_SERVER;
private static final ObjectName NIO_DIRECT_POOL;
private static final boolean HAS_MEMORY_USED_ATTRIBUTE;
+ private static final long MAX_DIRECT_MEMORY = PlatformDependent.estimateMaxDirectMemory();
static {
// initialize singletons. Only maintain a reference to the MBeanServer if
@@ -77,36 +76,9 @@ public class DirectMemoryUtils {
HAS_MEMORY_USED_ATTRIBUTE = a != null;
}
- /**
- * @return the setting of -XX:MaxDirectMemorySize as a long. Returns 0 if -XX:MaxDirectMemorySize
- * is not set.
- */
+ /** Returns the direct memory limit of the current progress */
public static long getDirectMemorySize() {
- RuntimeMXBean runtimemxBean = ManagementFactory.getRuntimeMXBean();
- List<String> arguments = runtimemxBean.getInputArguments();
- long multiplier = 1; // for the byte case.
- for (String s : arguments) {
- if (s.contains("-XX:MaxDirectMemorySize=")) {
- String memSize = s.toLowerCase(Locale.ROOT).replace("-xx:maxdirectmemorysize=", "").trim();
-
- if (memSize.contains("k")) {
- multiplier = 1024;
- }
-
- else if (memSize.contains("m")) {
- multiplier = 1048576;
- }
-
- else if (memSize.contains("g")) {
- multiplier = 1073741824;
- }
- memSize = memSize.replaceAll("[^\\d]", "");
-
- long retValue = Long.parseLong(memSize);
- return retValue * multiplier;
- }
- }
- return 0;
+ return MAX_DIRECT_MEMORY;
}
/** Returns the current amount of direct memory used. */
[hbase] 01/02: HBASE-27504 Remove duplicated config 'hbase.normalizer.merge.min_region_age.days' in hbase-default.xml (#4894)
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 1c9f6c5ccdf08c2ea0d385dc1262c0860c609e3b
Author: mokai <mo...@126.com>
AuthorDate: Wed Nov 23 18:54:00 2022 +0800
HBASE-27504 Remove duplicated config 'hbase.normalizer.merge.min_region_age.days' in hbase-default.xml (#4894)
Signed-off-by: Duo Zhang <zh...@apache.org>
(cherry picked from commit c691091f780150d41f6205666b6c221618567ee6)
---
hbase-common/src/main/resources/hbase-default.xml | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hbase-common/src/main/resources/hbase-default.xml b/hbase-common/src/main/resources/hbase-default.xml
index f0661adaba6..269c99dba27 100644
--- a/hbase-common/src/main/resources/hbase-default.xml
+++ b/hbase-common/src/main/resources/hbase-default.xml
@@ -643,11 +643,6 @@ possible configurations would overwhelm and obscure the important.
<value>3</value>
<description>The minimum age for a region to be considered for a merge, in days.</description>
</property>
- <property>
- <name>hbase.normalizer.merge.min_region_age.days</name>
- <value>3</value>
- <description>The minimum age for a region to be considered for a merge, in days.</description>
- </property>
<property>
<name>hbase.normalizer.merge.min_region_size.mb</name>
<value>1</value>