[GitHub] [hadoop] virajjasani commented on pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on PR #5349:
URL: https://github.com/apache/hadoop/pull/5349#issuecomment-1416664835

   > got me an initial feeling as something is broken with the way Datanode tracks last heartbeat.
   
   It's not broken, it's just that the lastHeartbeat is not sufficient to track realtime broken connection. Also I wanted to update existing metric only but in order to keep the compatibility, thought it would be better to add new metric with the name that suggests what it is doing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org