You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2023/09/03 03:44:34 UTC

[GitHub] [iceberg-rust] ZENOTME commented on a diff in pull request #56: feat: support read Manifest List

ZENOTME commented on code in PR #56:
URL: https://github.com/apache/iceberg-rust/pull/56#discussion_r1314088165


##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -84,7 +84,7 @@ pub struct Snapshot {
 /// Type to distinguish between a path to a manifestlist file or a vector of manifestfile locations
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)]
 #[serde(untagged)]
-pub enum ManifestList {
+pub enum ManifestListLocation {

Review Comment:
   It's conflict with `struct ManifestList` so I change it. I'm glad to use another better name or way to fix it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org