You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Fred Moyer <fr...@redhotpenguin.com> on 2010/08/22 20:02:05 UTC
Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Hi Torsten,
I put out a release candidate for Apache-Test 1.33 yesterday. Did you
see the email come through? An archive copy of it is located here:
http://www.gossamer-threads.com/lists/modperl/dev/101934
This commit puts us in a weird place; I can't really go forward with
testing the release candidate with features being added after it was
rolled like this was.
---------- Forwarded message ----------
From: <to...@apache.org>
Date: Sun, Aug 22, 2010 at 5:43 AM
Subject: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes
lib/Apache/TestConfigPerl.pm
To: test-commits@perl.apache.org
Author: torsten
Date: Sun Aug 22 12:43:45 2010
New Revision: 987890
URL: http://svn.apache.org/viewvc?rev=987890&view=rev
Log:
Propagate APACHE_TEST_NO_STICKY_PREFERENCES to the Apache environment.
Modified:
perl/Apache-Test/trunk/Changes
perl/Apache-Test/trunk/lib/Apache/TestConfigPerl.pm
Modified: perl/Apache-Test/trunk/Changes
URL: http://svn.apache.org/viewvc/perl/Apache-Test/trunk/Changes?rev=987890&r1=987889&r2=987890&view=diff
==============================================================================
--- perl/Apache-Test/trunk/Changes (original)
+++ perl/Apache-Test/trunk/Changes Sun Aug 22 12:43:45 2010
@@ -8,6 +8,11 @@ Changes - Apache::Test change logfile
=item 1.33-dev
+Propagate APACHE_TEST_NO_STICKY_PREFERENCES to the Apache environment
+for mod_perl configurations (Apache::TestConfigPerl),
+http://www.gossamer-threads.com/lists/modperl/dev/101929
+[Torsten Foertsch]
+
Provide build/test environment for modules bundled with mod_perl like
Apache::Reload and Apache::SizeLimit
[Torsten Foertsch]
Modified: perl/Apache-Test/trunk/lib/Apache/TestConfigPerl.pm
URL: http://svn.apache.org/viewvc/perl/Apache-Test/trunk/lib/Apache/TestConfigPerl.pm?rev=987890&r1=987889&r2=987890&view=diff
==============================================================================
--- perl/Apache-Test/trunk/lib/Apache/TestConfigPerl.pm (original)
+++ perl/Apache-Test/trunk/lib/Apache/TestConfigPerl.pm Sun Aug 22 12:43:45 2010
@@ -159,7 +159,8 @@ sub configure_env {
my $self = shift;
$self->preamble(IfModule => 'mod_perl.c',
[ qw(PerlPassEnv APACHE_TEST_TRACE_LEVEL
- PerlPassEnv HARNESS_PERL_SWITCHES)
+ PerlPassEnv HARNESS_PERL_SWITCHES
+ PerlPassEnv APACHE_TEST_NO_STICKY_PREFERENCES)
]);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Torsten Förtsch <to...@gmx.net>.
On Sunday, August 22, 2010 22:35:16 Fred Moyer wrote:
> Apache-Test's biggest drawback
> is lots and lots of hidden hooks and variables that very few people
> know how to use, and are not straightforward to find in the docs.
Very true. Unfortunately, I am not one of those people you mention. I have
poked around a bit, read much of the code but I can't say I understand it
completely.
Currently I am chasing for example the following bug. "make test" works for
one of my modules. "t/TEST -start-httpd; t/TEST -run-tests" fails. The started
server listens on 3 ports (VHosts). The test script uses the follwing code to
get the addresses of those VHosts:
Apache::TestRequest::module 'ssl';
$sslhostport=Apache::TestRequest::hostport;
t_debug "Using HTTPS @ $sslhostport";
Apache::TestRequest::module 'default';
$hostport=Apache::TestRequest::hostport;
t_debug "Using HTTP @ $hostport";
Now, it happens that when the server is started one set of ports is allocated
when the test runs t/conf/apache_test_config.pm is overwritten with another
set of ports. Don't know if it's my fault or Apache::Test's.
Torsten Förtsch
--
Need professional modperl support? Hire me! (http://foertsch.name)
Like fantasy? http://kabatinte.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Fred Moyer <fr...@redhotpenguin.com>.
2010/8/22 Torsten Förtsch <to...@gmx.net>:
> On Sunday, August 22, 2010 21:46:58 Fred Moyer wrote:
>> 2010/8/22 Torsten Förtsch <to...@gmx.net>:
>> > On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
>> >> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
>> >> see the email come through? An archive copy of it is located here:
>> >>
>> >> http://www.gossamer-threads.com/lists/modperl/dev/101934
>>
>> ...
>>
>> > However, I think that change should go to the release. It fixes a bug
>> > that can cause errors that are difficult to trace.
>>
>> Having encountered these errors before, I know they exist. However,
>> can you update the docs to provide some example usage? When I set
>> this variable, this happens on make test:
>>
>> You specified APACHE_TEST_NO_STICKY_PREFERENCES=1 in which case you
>> must explicitly specify -httpd and/or -apxs options
>>
>> And then make test -httpd=.... isn't something that will work.
>> Neither will it as a makefile arg. Can you add example usage for
>> those like me who know the hooks exist, but can't ever remember the
>> syntax?
>>
>>
>> phred@pooky ~/dev/svn/modperl/Apache-Test $ perl Makefile.PL
>> -httpd=/Users/phred/dev/sl/httpd/sbin/httpd
>> generating script t/TEST
>> generating script ./t/cgi-bin/cookies.pl
>> generating script ./t/cgi-bin/next_available_port.pl
>> '-HTTPD' is not a known MakeMaker parameter name.
>
> I believe this one you know:
>
> http://search.cpan.org/~phred/Apache-
> Test-1.32/lib/Apache/TestRun.pm#Persistent_Custom_Configuration
>
> Here is what I do in my SPEC files:
>
> %build
> export APACHE_TEST_NO_STICKY_PREFERENCES=1
> %perl Makefile.PL
> make %{?jobs:-j%jobs} &&
> t/TEST -apxs %{apxs} -httpd_conf %{sysconfdir}/original/httpd-modperl.conf
>
> I also think it would make more sense to pass these things as Makefile.PL
> parameters. Though, you can set them as environment variables.
Duh - forgot about being able to set those as environment variables.
So we have a mix of Makefile.PL parameters and environment variables
controlling behavior. I've got my head in this code as much as anyone
else, and I have no idea of what all of those are. MOD_PERL_1_BUILD,
and friends are all over the place.
Can you add the environment variable options to the docs you added?
If an unaware user runs 'make test' with this variable enabled, they
basically hit a dead end in terms of usage if they don't remember
APACHE_TEST_APXS et. al. (remember that the user is not reminded of
that variable unless they successfully execute perl Makefile.PL, since
it dies before that reminder is shown).
I don't mind rolling another RC, but if features are going in (since
there is bug report for this issue I'm calling it a feature), then
they should be really well documented. Apache-Test's biggest drawback
is lots and lots of hidden hooks and variables that very few people
know how to use, and are not straightforward to find in the docs.
> I have set in my environment APACHE_TEST_NO_STICKY_PREFERENCES=1 and
> APACHE_TEST_APXS=/path/to/apxs. That is enough to make "make test" work.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Torsten Förtsch <to...@gmx.net>.
On Sunday, August 22, 2010 21:46:58 Fred Moyer wrote:
> 2010/8/22 Torsten Förtsch <to...@gmx.net>:
> > On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
> >> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> >> see the email come through? An archive copy of it is located here:
> >>
> >> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> ...
>
> > However, I think that change should go to the release. It fixes a bug
> > that can cause errors that are difficult to trace.
>
> Having encountered these errors before, I know they exist. However,
> can you update the docs to provide some example usage? When I set
> this variable, this happens on make test:
>
> You specified APACHE_TEST_NO_STICKY_PREFERENCES=1 in which case you
> must explicitly specify -httpd and/or -apxs options
>
> And then make test -httpd=.... isn't something that will work.
> Neither will it as a makefile arg. Can you add example usage for
> those like me who know the hooks exist, but can't ever remember the
> syntax?
>
>
> phred@pooky ~/dev/svn/modperl/Apache-Test $ perl Makefile.PL
> -httpd=/Users/phred/dev/sl/httpd/sbin/httpd
> generating script t/TEST
> generating script ./t/cgi-bin/cookies.pl
> generating script ./t/cgi-bin/next_available_port.pl
> '-HTTPD' is not a known MakeMaker parameter name.
I believe this one you know:
http://search.cpan.org/~phred/Apache-
Test-1.32/lib/Apache/TestRun.pm#Persistent_Custom_Configuration
Here is what I do in my SPEC files:
%build
export APACHE_TEST_NO_STICKY_PREFERENCES=1
%perl Makefile.PL
make %{?jobs:-j%jobs} &&
t/TEST -apxs %{apxs} -httpd_conf %{sysconfdir}/original/httpd-modperl.conf
I also think it would make more sense to pass these things as Makefile.PL
parameters. Though, you can set them as environment variables.
I have set in my environment APACHE_TEST_NO_STICKY_PREFERENCES=1 and
APACHE_TEST_APXS=/path/to/apxs. That is enough to make "make test" work.
Torsten Förtsch
--
Need professional modperl support? Hire me! (http://foertsch.name)
Like fantasy? http://kabatinte.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Torsten Förtsch <to...@gmx.net>.
On Sunday, August 22, 2010 21:46:58 Fred Moyer wrote:
> 2010/8/22 Torsten Förtsch <to...@gmx.net>:
> > On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
> >> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> >> see the email come through? An archive copy of it is located here:
> >>
> >> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> ...
>
> > However, I think that change should go to the release. It fixes a bug
> > that can cause errors that are difficult to trace.
>
> Having encountered these errors before, I know they exist. However,
> can you update the docs to provide some example usage? When I set
> this variable, this happens on make test:
>
> You specified APACHE_TEST_NO_STICKY_PREFERENCES=1 in which case you
> must explicitly specify -httpd and/or -apxs options
>
> And then make test -httpd=.... isn't something that will work.
> Neither will it as a makefile arg. Can you add example usage for
> those like me who know the hooks exist, but can't ever remember the
> syntax?
>
>
> phred@pooky ~/dev/svn/modperl/Apache-Test $ perl Makefile.PL
> -httpd=/Users/phred/dev/sl/httpd/sbin/httpd
> generating script t/TEST
> generating script ./t/cgi-bin/cookies.pl
> generating script ./t/cgi-bin/next_available_port.pl
> '-HTTPD' is not a known MakeMaker parameter name.
I believe this one you know:
http://search.cpan.org/~phred/Apache-
Test-1.32/lib/Apache/TestRun.pm#Persistent_Custom_Configuration
Here is what I do in my SPEC files:
%build
export APACHE_TEST_NO_STICKY_PREFERENCES=1
%perl Makefile.PL
make %{?jobs:-j%jobs} &&
t/TEST -apxs %{apxs} -httpd_conf %{sysconfdir}/original/httpd-modperl.conf
I also think it would make more sense to pass these things as Makefile.PL
parameters. Though, you can set them as environment variables.
I have set in my environment APACHE_TEST_NO_STICKY_PREFERENCES=1 and
APACHE_TEST_APXS=/path/to/apxs. That is enough to make "make test" work.
Torsten Förtsch
--
Need professional modperl support? Hire me! (http://foertsch.name)
Like fantasy? http://kabatinte.net
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Fred Moyer <fr...@redhotpenguin.com>.
2010/8/22 Torsten Förtsch <to...@gmx.net>:
> On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
>> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
>> see the email come through? An archive copy of it is located here:
>>
>> http://www.gossamer-threads.com/lists/modperl/dev/101934
...
> However, I think that change should go to the release. It fixes a bug that can
> cause errors that are difficult to trace.
Having encountered these errors before, I know they exist. However,
can you update the docs to provide some example usage? When I set
this variable, this happens on make test:
You specified APACHE_TEST_NO_STICKY_PREFERENCES=1 in which case you
must explicitly specify -httpd and/or -apxs options
And then make test -httpd=.... isn't something that will work.
Neither will it as a makefile arg. Can you add example usage for
those like me who know the hooks exist, but can't ever remember the
syntax?
phred@pooky ~/dev/svn/modperl/Apache-Test $ perl Makefile.PL
-httpd=/Users/phred/dev/sl/httpd/sbin/httpd
generating script t/TEST
generating script ./t/cgi-bin/cookies.pl
generating script ./t/cgi-bin/next_available_port.pl
'-HTTPD' is not a known MakeMaker parameter name.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Torsten Förtsch <to...@gmx.net>.
On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> see the email come through? An archive copy of it is located here:
>
> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> This commit puts us in a weird place; I can't really go forward with
> testing the release candidate with features being added after it was
> rolled like this was.
Oops, I missed that, sorry! Now, that you mention it I recall having seen
something.
However, I think that change should go to the release. It fixes a bug that can
cause errors that are difficult to trace.
Suppose a RPM/debian package provider builds a package for a mod_perl based
module. He'll probably set APACHE_TEST_NO_STICKY_PREFERENCES to prevent
~/.apache-test/... to be written. Now, the module contains a
t/TESTlib/something or so that uses Apache::Test itself. AT then is not aware
of APACHE_TEST_NO_STICKY_PREFERENCES and tries to save the config. This may
write ~/.apache-test/Apache/TestConfigData.pm or, worse, it may place
Apache/TestConfigData.pm somewhere in @INC in the package being built. This
may get through unnoticed and in the end the package contains a config that
does not match the system.
So, had I noticed I'd given you a -1 anyway.
Torsten Förtsch
--
Need professional modperl support? Hire me! (http://foertsch.name)
Like fantasy? http://kabatinte.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Posted by Torsten Förtsch <to...@gmx.net>.
On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> see the email come through? An archive copy of it is located here:
>
> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> This commit puts us in a weird place; I can't really go forward with
> testing the release candidate with features being added after it was
> rolled like this was.
Oops, I missed that, sorry! Now, that you mention it I recall having seen
something.
However, I think that change should go to the release. It fixes a bug that can
cause errors that are difficult to trace.
Suppose a RPM/debian package provider builds a package for a mod_perl based
module. He'll probably set APACHE_TEST_NO_STICKY_PREFERENCES to prevent
~/.apache-test/... to be written. Now, the module contains a
t/TESTlib/something or so that uses Apache::Test itself. AT then is not aware
of APACHE_TEST_NO_STICKY_PREFERENCES and tries to save the config. This may
write ~/.apache-test/Apache/TestConfigData.pm or, worse, it may place
Apache/TestConfigData.pm somewhere in @INC in the package being built. This
may get through unnoticed and in the end the package contains a config that
does not match the system.
So, had I noticed I'd given you a -1 anyway.
Torsten Förtsch
--
Need professional modperl support? Hire me! (http://foertsch.name)
Like fantasy? http://kabatinte.net
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes
lib/Apache/TestConfigPerl.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
On 8/22/2010 2:02 PM, Fred Moyer wrote:
> Hi Torsten,
>
> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> see the email come through? An archive copy of it is located here:
>
> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> This commit puts us in a weird place; I can't really go forward with
> testing the release candidate with features being added after it was
> rolled like this was.
Sure you can. As RM you have final say of what makes it and what
doesn't. If you don't want it, branch from the previuos rev and roll
the rc from that. If you want it retracted -rc1 and roll -rc2.
--
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer, FreeBSD Foundation
Consultant, P6M7G8 Inc.
Sr. System Admin, Ridecharge Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes
lib/Apache/TestConfigPerl.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
On 8/22/2010 2:02 PM, Fred Moyer wrote:
> Hi Torsten,
>
> I put out a release candidate for Apache-Test 1.33 yesterday. Did you
> see the email come through? An archive copy of it is located here:
>
> http://www.gossamer-threads.com/lists/modperl/dev/101934
>
> This commit puts us in a weird place; I can't really go forward with
> testing the release candidate with features being added after it was
> rolled like this was.
Sure you can. As RM you have final say of what makes it and what
doesn't. If you don't want it, branch from the previuos rev and roll
the rc from that. If you want it retracted -rc1 and roll -rc2.
--
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer, FreeBSD Foundation
Consultant, P6M7G8 Inc.
Sr. System Admin, Ridecharge Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org