You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/08/03 06:10:51 UTC

[GitHub] [zeppelin] Reamer commented on a change in pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Reamer commented on a change in pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173#discussion_r681461670



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -106,7 +106,7 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage rec
               " to false if you want to use other modes.");
     }
 
-    StringBuilder sparkConfBuilder = new StringBuilder();
+    List<String> sparkConfList = new ArrayList<>();

Review comment:
       A StringJoiner is more elegant
   
   https://docs.oracle.com/javase/8/docs/api/java/util/StringJoiner.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org