About the Partial Page Rendering Commit ...

[Ernst Fastl <er...@gmail.com>]

Hi There!

Since the recent commit brought quite some comments and advices in different
threads I'll try to comment on what I understand as the outcome of
that discussions
in this mail.

>For a substantial contribution like this, we'll need a CLA on file in
>any case (even if the code came in through a jira-issue).

>Is the original author of these classes willing to sign and fax in a CLA[2]?
>If so, that gets us over the first hurdle.  If not, the files should
definitely be removed.

I signed and faxed it today in the morning, so you all can be sure
that this is apaches
code now. Sorry that I haven't done that before, I did not know that
this is also necessary
if another commiter commits the code for you. I should have gathered
more information of the
process of apache contributions - to be honest I just didn't think of
any legal issues.

>I am not concerned about the icla or not
>I am more concerned about the fact that patches sent offline
>and not through Jira.

I'm also sorry for that one. I just thought it would be good to
provide some code which
implements what I think came out of the initial discussions, before
starting to talk
on the mailing list of things that do not already exist. That was
probably the wrong direction
and I will try hard to communicate more efficiently with the
community in the future.

>The second problem is one that Wendy pointed out ... lack of license
headers on the source files.

Again I can only apologize, I just didn't think of that - sorry.

>The sort of "offline" development. Sending offline a patch to a
>committer for letting him commit the stuff is to me a -1. Looks like a
>"bypass".

I really didn't mean to bypass confirmation or evaluation of the
community. I just thougth
if the code is commited to the sandbox that this doesn't cause any
harm and all people that
want to verify the code can take a look there and give feedback.

>Matthias, you're absolutely right - I'm just as concerned as you about
>offline development, and asked Ernst several times to engage in an
>discussion on the mailing list.

All together I can only apologize for all those beginners misstakes. I
am still new to Open Source
Development and although it may have produced a different image I just
had the best intentions.
Thanks to all the comments that came up after this commit I belive I
learned a lot of things
about how the ASF works and will hopefully be able to avoid such
beginners misstakes in the future.

kind regards

Ernst

Re: About the Partial Page Rendering Commit ...

[Matthias Wessendorf <ma...@apache.org>]

It's good that everybody learns each day :)

after following this thread everybody knows (or should)
-iCLA is important
-going through the community is important

and Ernst did a nice job.

amen :)

On 8/24/06, Werner Punz <we...@gmx.at> wrote:
> Actually I have to take some blame on me as well,
> when Ernst asked me on how to get the code in
> I told him to ask Catalin to do it, because
> they currently share the same location in Frankfurt.
> To my blame I was not aware of the entire ICLA issue.
>
> Anway, please lets stop this discussion for now.
> I had a look at the final PPR renderer yesterday
> night when I was preparing a fixup for a another component
> in the codebase, and it looked excellent.
> Ernst has done a tremendous job with this one.
> (I have seen parts of it before, but not the final one)
>
>
> Werner
>
>
> Martin Marinschek schrieb:
> > If I take on some SoC students next year, I'll make sure this happens
> > early on (with slightly more pressure than this year, cause I did ask
> > for filling out the ICLA in the beginning already this year, but not
> > everyone sent something in....).
> >
> > regards,
> >
> > Martin
> >
>
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: About the Partial Page Rendering Commit ...

[Werner Punz <we...@gmx.at>]

Actually I have to take some blame on me as well,
when Ernst asked me on how to get the code in
I told him to ask Catalin to do it, because
they currently share the same location in Frankfurt.
To my blame I was not aware of the entire ICLA issue.

Anway, please lets stop this discussion for now.
I had a look at the final PPR renderer yesterday
night when I was preparing a fixup for a another component
in the codebase, and it looked excellent.
Ernst has done a tremendous job with this one.
(I have seen parts of it before, but not the final one)


Werner


Martin Marinschek schrieb:
> If I take on some SoC students next year, I'll make sure this happens
> early on (with slightly more pressure than this year, cause I did ask
> for filling out the ICLA in the beginning already this year, but not
> everyone sent something in....).
> 
> regards,
> 
> Martin
> 

Re: About the Partial Page Rendering Commit ...

[Martin Marinschek <ma...@gmail.com>]

If I take on some SoC students next year, I'll make sure this happens
early on (with slightly more pressure than this year, cause I did ask
for filling out the ICLA in the beginning already this year, but not
everyone sent something in....).

regards,

Martin

On 8/24/06, Craig McClanahan <cr...@apache.org> wrote:
> On 8/24/06, Catalin Kormos <ca...@yahoo.com> wrote:
>
> >
> > Hi guys,
> >
> > Sorry for the late reaction. Just want to say that i'm sorry about the
> > situation, I should have been more carefull, and this sort of things won't
> > happen next time. All your reactions were quite usefull and made me learn
> a
> > lot about ASF.
>
>
> I don't think anyone feels that either Ernst or Catalin had any evil motives
> in all of this (I certainly don't).  But it's pretty clear we (Apache) need
> to improve the education process for new committers (as they come on board
> in a particular project), and perhaps we can rearrange the steps for Google
> Summer of Code contributions (if the program happens again next summer), but
> having the ICLA gotten out of the way early.
>
> Craig
>
>
> > Best regards,
> > Catalin
> >
> >
> > Matthias Wessendorf-4 wrote:
> > >
> > > Ernst,
> > >
> > > glad you replyed to some comments. The MyFaces community trys the best
> > > to help users with how OS development works. You are very welcome
> > > here. The ASF is not all about code, those the guide is important. One
> > > document to read is [1] if you have *enhancements* to that. they are
> > > welcome. Provide a patch for the infra team ;)
> > >
> > > I now think we should move back to work.
> > > Thanks for the contribution
> > >
> > > [1] http://www.apache.org/foundation/how-it-works.html
> > >
> > > On 8/23/06, Ernst Fastl <ernst.fastl@gmail.com > wrote:
> > >> Hi There!
> > >>
> > >> Since the recent commit brought quite some comments and advices in
> > >> different
> > >> threads I'll try to comment on what I understand as the outcome of
> > >> that discussions
> > >> in this mail.
> > >>
> > >> >For a substantial contribution like this, we'll need a CLA on file in
> > >> >any case (even if the code came in through a jira-issue).
> > >>
> > >> >Is the original author of these classes willing to sign and fax in a
> > >> CLA[2]?
> > >> >If so, that gets us over the first hurdle.  If not, the files should
> > >> definitely be removed.
> > >>
> > >> I signed and faxed it today in the morning, so you all can be sure
> > >> that this is apaches
> > >> code now. Sorry that I haven't done that before, I did not know that
> > >> this is also necessary
> > >> if another commiter commits the code for you. I should have gathered
> > >> more information of the
> > >> process of apache contributions - to be honest I just didn't think of
> > >> any legal issues.
> > >>
> > >> >I am not concerned about the icla or not
> > >> >I am more concerned about the fact that patches sent offline
> > >> >and not through Jira.
> > >>
> > >> I'm also sorry for that one. I just thought it would be good to
> > >> provide some code which
> > >> implements what I think came out of the initial discussions, before
> > >> starting to talk
> > >> on the mailing list of things that do not already exist. That was
> > >> probably the wrong direction
> > >> and I will try hard to communicate more efficiently with the
> > >> community in the future.
> > >>
> > >> >The second problem is one that Wendy pointed out ... lack of license
> > >> headers on the source files.
> > >>
> > >> Again I can only apologize, I just didn't think of that - sorry.
> > >>
> > >> >The sort of "offline" development. Sending offline a patch to a
> > >> >committer for letting him commit the stuff is to me a -1. Looks like a
> > >> >"bypass".
> > >>
> > >> I really didn't mean to bypass confirmation or evaluation of the
> > >> community. I just thougth
> > >> if the code is commited to the sandbox that this doesn't cause any
> > >> harm and all people that
> > >> want to verify the code can take a look there and give feedback.
> > >>
> > >> >Matthias, you're absolutely right - I'm just as concerned as you about
> > >> >offline development, and asked Ernst several times to engage in an
> > >> >discussion on the mailing list.
> > >>
> > >> All together I can only apologize for all those beginners misstakes. I
> > >> am still new to Open Source
> > >> Development and although it may have produced a different image I just
> > >> had the best intentions.
> > >> Thanks to all the comments that came up after this commit I belive I
> > >> learned a lot of things
> > >> about how the ASF works and will hopefully be able to avoid such
> > >> beginners misstakes in the future.
> > >>
> > >> kind regards
> > >>
> > >> Ernst
> > >>
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> > >
> >
> > --
> > View this message in context:
> http://www.nabble.com/About-the-Partial-Page-Rendering-Commit-...-tf2153656.html#a5962006
> > Sent from the My Faces - Dev forum at Nabble.com.
> >
> >
>
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Re: About the Partial Page Rendering Commit ...

[Craig McClanahan <cr...@apache.org>]

On 8/24/06, Catalin Kormos <ca...@yahoo.com> wrote:
>
>
> Hi guys,
>
> Sorry for the late reaction. Just want to say that i'm sorry about the
> situation, I should have been more carefull, and this sort of things won't
> happen next time. All your reactions were quite usefull and made me learn
> a
> lot about ASF.


I don't think anyone feels that either Ernst or Catalin had any evil motives
in all of this (I certainly don't).  But it's pretty clear we (Apache) need
to improve the education process for new committers (as they come on board
in a particular project), and perhaps we can rearrange the steps for Google
Summer of Code contributions (if the program happens again next summer), but
having the ICLA gotten out of the way early.

Craig

Best regards,
> Catalin
>
>
> Matthias Wessendorf-4 wrote:
> >
> > Ernst,
> >
> > glad you replyed to some comments. The MyFaces community trys the best
> > to help users with how OS development works. You are very welcome
> > here. The ASF is not all about code, those the guide is important. One
> > document to read is [1] if you have *enhancements* to that. they are
> > welcome. Provide a patch for the infra team ;)
> >
> > I now think we should move back to work.
> > Thanks for the contribution
> >
> > [1] http://www.apache.org/foundation/how-it-works.html
> >
> > On 8/23/06, Ernst Fastl <er...@gmail.com> wrote:
> >> Hi There!
> >>
> >> Since the recent commit brought quite some comments and advices in
> >> different
> >> threads I'll try to comment on what I understand as the outcome of
> >> that discussions
> >> in this mail.
> >>
> >> >For a substantial contribution like this, we'll need a CLA on file in
> >> >any case (even if the code came in through a jira-issue).
> >>
> >> >Is the original author of these classes willing to sign and fax in a
> >> CLA[2]?
> >> >If so, that gets us over the first hurdle.  If not, the files should
> >> definitely be removed.
> >>
> >> I signed and faxed it today in the morning, so you all can be sure
> >> that this is apaches
> >> code now. Sorry that I haven't done that before, I did not know that
> >> this is also necessary
> >> if another commiter commits the code for you. I should have gathered
> >> more information of the
> >> process of apache contributions - to be honest I just didn't think of
> >> any legal issues.
> >>
> >> >I am not concerned about the icla or not
> >> >I am more concerned about the fact that patches sent offline
> >> >and not through Jira.
> >>
> >> I'm also sorry for that one. I just thought it would be good to
> >> provide some code which
> >> implements what I think came out of the initial discussions, before
> >> starting to talk
> >> on the mailing list of things that do not already exist. That was
> >> probably the wrong direction
> >> and I will try hard to communicate more efficiently with the
> >> community in the future.
> >>
> >> >The second problem is one that Wendy pointed out ... lack of license
> >> headers on the source files.
> >>
> >> Again I can only apologize, I just didn't think of that - sorry.
> >>
> >> >The sort of "offline" development. Sending offline a patch to a
> >> >committer for letting him commit the stuff is to me a -1. Looks like a
> >> >"bypass".
> >>
> >> I really didn't mean to bypass confirmation or evaluation of the
> >> community. I just thougth
> >> if the code is commited to the sandbox that this doesn't cause any
> >> harm and all people that
> >> want to verify the code can take a look there and give feedback.
> >>
> >> >Matthias, you're absolutely right - I'm just as concerned as you about
> >> >offline development, and asked Ernst several times to engage in an
> >> >discussion on the mailing list.
> >>
> >> All together I can only apologize for all those beginners misstakes. I
> >> am still new to Open Source
> >> Development and although it may have produced a different image I just
> >> had the best intentions.
> >> Thanks to all the comments that came up after this commit I belive I
> >> learned a lot of things
> >> about how the ASF works and will hopefully be able to avoid such
> >> beginners misstakes in the future.
> >>
> >> kind regards
> >>
> >> Ernst
> >>
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/About-the-Partial-Page-Rendering-Commit-...-tf2153656.html#a5962006
> Sent from the My Faces - Dev forum at Nabble.com.
>
>

Re: About the Partial Page Rendering Commit ...

[Catalin Kormos <ca...@yahoo.com>]

Hi guys,

Sorry for the late reaction. Just want to say that i'm sorry about the
situation, I should have been more carefull, and this sort of things won't
happen next time. All your reactions were quite usefull and made me learn a
lot about ASF.

Best regards,
Catalin


Matthias Wessendorf-4 wrote:
> 
> Ernst,
> 
> glad you replyed to some comments. The MyFaces community trys the best
> to help users with how OS development works. You are very welcome
> here. The ASF is not all about code, those the guide is important. One
> document to read is [1] if you have *enhancements* to that. they are
> welcome. Provide a patch for the infra team ;)
> 
> I now think we should move back to work.
> Thanks for the contribution
> 
> [1] http://www.apache.org/foundation/how-it-works.html
> 
> On 8/23/06, Ernst Fastl <er...@gmail.com> wrote:
>> Hi There!
>>
>> Since the recent commit brought quite some comments and advices in
>> different
>> threads I'll try to comment on what I understand as the outcome of
>> that discussions
>> in this mail.
>>
>> >For a substantial contribution like this, we'll need a CLA on file in
>> >any case (even if the code came in through a jira-issue).
>>
>> >Is the original author of these classes willing to sign and fax in a
>> CLA[2]?
>> >If so, that gets us over the first hurdle.  If not, the files should
>> definitely be removed.
>>
>> I signed and faxed it today in the morning, so you all can be sure
>> that this is apaches
>> code now. Sorry that I haven't done that before, I did not know that
>> this is also necessary
>> if another commiter commits the code for you. I should have gathered
>> more information of the
>> process of apache contributions - to be honest I just didn't think of
>> any legal issues.
>>
>> >I am not concerned about the icla or not
>> >I am more concerned about the fact that patches sent offline
>> >and not through Jira.
>>
>> I'm also sorry for that one. I just thought it would be good to
>> provide some code which
>> implements what I think came out of the initial discussions, before
>> starting to talk
>> on the mailing list of things that do not already exist. That was
>> probably the wrong direction
>> and I will try hard to communicate more efficiently with the
>> community in the future.
>>
>> >The second problem is one that Wendy pointed out ... lack of license
>> headers on the source files.
>>
>> Again I can only apologize, I just didn't think of that - sorry.
>>
>> >The sort of "offline" development. Sending offline a patch to a
>> >committer for letting him commit the stuff is to me a -1. Looks like a
>> >"bypass".
>>
>> I really didn't mean to bypass confirmation or evaluation of the
>> community. I just thougth
>> if the code is commited to the sandbox that this doesn't cause any
>> harm and all people that
>> want to verify the code can take a look there and give feedback.
>>
>> >Matthias, you're absolutely right - I'm just as concerned as you about
>> >offline development, and asked Ernst several times to engage in an
>> >discussion on the mailing list.
>>
>> All together I can only apologize for all those beginners misstakes. I
>> am still new to Open Source
>> Development and although it may have produced a different image I just
>> had the best intentions.
>> Thanks to all the comments that came up after this commit I belive I
>> learned a lot of things
>> about how the ASF works and will hopefully be able to avoid such
>> beginners misstakes in the future.
>>
>> kind regards
>>
>> Ernst
>>
> 
> 
> -- 
> Matthias Wessendorf
> 
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
> 
> 

-- 
View this message in context: http://www.nabble.com/About-the-Partial-Page-Rendering-Commit-...-tf2153656.html#a5962006
Sent from the My Faces - Dev forum at Nabble.com.

Re: About the Partial Page Rendering Commit ...

[Matthias Wessendorf <ma...@apache.org>]

Ernst,

glad you replyed to some comments. The MyFaces community trys the best
to help users with how OS development works. You are very welcome
here. The ASF is not all about code, those the guide is important. One
document to read is [1] if you have *enhancements* to that. they are
welcome. Provide a patch for the infra team ;)

I now think we should move back to work.
Thanks for the contribution

[1] http://www.apache.org/foundation/how-it-works.html

On 8/23/06, Ernst Fastl <er...@gmail.com> wrote:
> Hi There!
>
> Since the recent commit brought quite some comments and advices in different
> threads I'll try to comment on what I understand as the outcome of
> that discussions
> in this mail.
>
> >For a substantial contribution like this, we'll need a CLA on file in
> >any case (even if the code came in through a jira-issue).
>
> >Is the original author of these classes willing to sign and fax in a CLA[2]?
> >If so, that gets us over the first hurdle.  If not, the files should
> definitely be removed.
>
> I signed and faxed it today in the morning, so you all can be sure
> that this is apaches
> code now. Sorry that I haven't done that before, I did not know that
> this is also necessary
> if another commiter commits the code for you. I should have gathered
> more information of the
> process of apache contributions - to be honest I just didn't think of
> any legal issues.
>
> >I am not concerned about the icla or not
> >I am more concerned about the fact that patches sent offline
> >and not through Jira.
>
> I'm also sorry for that one. I just thought it would be good to
> provide some code which
> implements what I think came out of the initial discussions, before
> starting to talk
> on the mailing list of things that do not already exist. That was
> probably the wrong direction
> and I will try hard to communicate more efficiently with the
> community in the future.
>
> >The second problem is one that Wendy pointed out ... lack of license
> headers on the source files.
>
> Again I can only apologize, I just didn't think of that - sorry.
>
> >The sort of "offline" development. Sending offline a patch to a
> >committer for letting him commit the stuff is to me a -1. Looks like a
> >"bypass".
>
> I really didn't mean to bypass confirmation or evaluation of the
> community. I just thougth
> if the code is commited to the sandbox that this doesn't cause any
> harm and all people that
> want to verify the code can take a look there and give feedback.
>
> >Matthias, you're absolutely right - I'm just as concerned as you about
> >offline development, and asked Ernst several times to engage in an
> >discussion on the mailing list.
>
> All together I can only apologize for all those beginners misstakes. I
> am still new to Open Source
> Development and although it may have produced a different image I just
> had the best intentions.
> Thanks to all the comments that came up after this commit I belive I
> learned a lot of things
> about how the ASF works and will hopefully be able to avoid such
> beginners misstakes in the future.
>
> kind regards
>
> Ernst
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com