You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/13 22:41:15 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17010: [API] unified API for custom kvstores

apeforest commented on a change in pull request #17010: [API] unified API for custom kvstores
URL: https://github.com/apache/incubator-mxnet/pull/17010#discussion_r357850748
 
 

 ##########
 File path: python/mxnet/__init__.py
 ##########
 @@ -84,22 +86,20 @@
 from . import test_utils
 
 from . import rnn
-
 from . import gluon
 
-# Dynamic library module should be done after ndarray and symbol are initialized
-from . import library
-from . import tvmop
-
-__version__ = base.__version__
-
+# use mx.kv as short for kvstore
 # Dist kvstore module which launches a separate process when role is set to "server".
 
 Review comment:
   Maybe you also want to update the comment here. In the case of HVD, there will be no "server" process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services