You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2017/09/15 23:36:32 UTC
[1/2] beam git commit: [BEAM-2808] Improving error message in
ParDo.validateWindowTypeForMethod.
Repository: beam
Updated Branches:
refs/heads/master 0b6958636 -> bd0facc46
[BEAM-2808] Improving error message in ParDo.validateWindowTypeForMethod.
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/3e514ce8
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/3e514ce8
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/3e514ce8
Branch: refs/heads/master
Commit: 3e514ce847b066059525495758a784e9f75fe7aa
Parents: 0b69586
Author: Daniel Oliveira <da...@gmail.com>
Authored: Fri Sep 15 12:10:05 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Fri Sep 15 16:36:00 2017 -0700
----------------------------------------------------------------------
.../core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/3e514ce8/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
index a0e1eb2..49343c7 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
@@ -537,7 +537,8 @@ public class ParDo {
if (methodSignature.windowT() != null) {
checkArgument(
methodSignature.windowT().isSupertypeOf(actualWindowT),
- "%s expects window type %s, which is not a supertype of actual window type %s",
+ "%s unable to provide window -- expected window type from parameter (%s) is not a "
+ + "supertype of actual window type assigned by windowing (%s)",
methodSignature.targetMethod(),
methodSignature.windowT(),
actualWindowT);
[2/2] beam git commit: [BEAM-2808] Improve error message when DoFn
@ProcessElement has the wrong window type
Posted by lc...@apache.org.
[BEAM-2808] Improve error message when DoFn @ProcessElement has the wrong window type
This closes #3857
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/bd0facc4
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/bd0facc4
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/bd0facc4
Branch: refs/heads/master
Commit: bd0facc469b2312dd7ca2e2a7161c5562cd58b36
Parents: 0b69586 3e514ce
Author: Luke Cwik <lc...@google.com>
Authored: Fri Sep 15 16:36:25 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Fri Sep 15 16:36:25 2017 -0700
----------------------------------------------------------------------
.../core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------