You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:58:32 UTC

[GitHub] [arrow] andygrove commented on a change in pull request #8936: ARROW-10938: [Rust] upgrade dependency "flatbuffers" to 0.8

andygrove commented on a change in pull request #8936:
URL: https://github.com/apache/arrow/pull/8936#discussion_r544366618



##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -124,8 +124,11 @@ pub fn fb_to_schema(fb: ipc::Schema) -> Schema {
 
 /// Deserialize an IPC message into a schema
 pub fn schema_from_bytes(bytes: &[u8]) -> Option<Schema> {

Review comment:
       Should we change this function to return `Result<Schema>` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org