You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Ning Zhang (Jira)" <ji...@apache.org> on 2020/09/09 15:00:12 UTC

[jira] [Comment Edited] (KAFKA-10304) Revisit and improve the tests of MirrorMaker 2

    [ https://issues.apache.org/jira/browse/KAFKA-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192664#comment-17192664 ] 

Ning Zhang edited comment on KAFKA-10304 at 9/9/20, 3:00 PM:
-------------------------------------------------------------

Hi [~mimaison] [~ryannedolan] this is mostly a refactoring pr on the MM2 integration tests. The purpose of doing that: (1) address the concern in [a previous PR|https://github.com/apache/kafka/pull/9029#issuecomment-663094946], (2) prepare for the future development (e.g. extract common functions). I think the current PR ([https://github.com/apache/kafka/pull/9224]) is just a starting point, and I am very appreciated for your feedback on what to test additionally and how to get close to the real scenario.


was (Author: yangguo1220):
Hi [~mimaison] [~ryannedolan] this is mostly a refactoring pr on the MM2 integration tests. The purpose of doing that: (1) address the concern in the previous PR (https://github.com/apache/kafka/pull/9029), (2) prepare for the future development (e.g. extract common functions). I think the current PR (https://github.com/apache/kafka/pull/9224) is just a starting point, and I am very appreciated for your feedback on what to test additionally and how to get close to the real scenario.

> Revisit and improve the tests of MirrorMaker 2
> ----------------------------------------------
>
>                 Key: KAFKA-10304
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10304
>             Project: Kafka
>          Issue Type: Test
>          Components: KafkaConnect, mirrormaker
>            Reporter: Ning Zhang
>            Assignee: Ning Zhang
>            Priority: Minor
>             Fix For: 2.8.0
>
>
> In a different MM2 change, [some concerns|https://github.com/apache/kafka/pull/9029#issuecomment-663094946] on tests were raised. It may be a good time to revisit and refactor the tests, possibly in the following way:
> (1) are 100 messages good enough for integration tests?
>  (2) what about the broker failure in the middle of integration tests?
>  (3) other validations to check (e.g. topic config sync....)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)