You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Hans Gilde <hg...@gmail.com> on 2005/01/20 06:32:32 UTC
[jelly] RC2?
I couldn't fix the problems with my weak ref implementation, so I tweaked
Paul's fix a little to make it thread safe and better for inheritance.
Anyway, the memory leak is gone and all unit tests pass after many
iterations.
Are we ready for an RC2 and, hopefully, a quick release of version 1?
Hans
Re: [jelly] RC2?
Posted by Paul Libbrecht <pa...@activemath.org>.
FileTag is in core which I presume would be released along Jelly...
Or did someone plan to release jelly-core separately ?
paul
Le 21 janv. 05, à 02:38, Hans Gilde a écrit :
> I'm for fixing JELLY-177 and JELLY-196 (haven't really looked at 196,
> just
> the description). 191 is for a TagLib, so it would be released
> separately
> anyway.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jelly] RC2?
Posted by Hans Gilde <hg...@earthlink.net>.
I'm for fixing JELLY-177 and JELLY-196 (haven't really looked at 196, just
the description). 191 is for a TagLib, so it would be released separately
anyway.
The code for JELLY-177 looks good when copied verbatim. I did a couple of
Servlet tests but nothing that could be automated without Cactus. Will
commit this tonight or tomorrow after a little more testing.
Hans
-----Original Message-----
From: Paul Libbrecht [mailto:paul@activemath.org]
Sent: Thursday, January 20, 2005 3:45 AM
To: Jakarta Commons Developers List
Subject: Re: [jelly] RC2?
We should maybe make a round of the bugs submitted, or ?
Hans mentioned he wanted to give a stab at JELLY-177, looks good.
Looks like JELLY-191 and JELLY-196 could be considered...
Any opinion ?
paul
Le 20 janv. 05, à 06:43, Dion Gillard a écrit :
> Yep, I'm up for RC2 after some testing and then assuming no
> showstoppers, a 1.0 straight after.
>
> On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com>
> wrote:
>> I couldn't fix the problems with my weak ref implementation, so I
>> tweaked
>> Paul's fix a little to make it thread safe and better for inheritance.
>>
>> Anyway, the memory leak is gone and all unit tests pass after many
>> iterations.
>>
>> Are we ready for an RC2 and, hopefully, a quick release of version 1?
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [jelly] RC2?
Posted by Paul Libbrecht <pa...@activemath.org>.
We should maybe make a round of the bugs submitted, or ?
Hans mentioned he wanted to give a stab at JELLY-177, looks good.
Looks like JELLY-191 and JELLY-196 could be considered...
Any opinion ?
paul
Le 20 janv. 05, à 06:43, Dion Gillard a écrit :
> Yep, I'm up for RC2 after some testing and then assuming no
> showstoppers, a 1.0 straight after.
>
> On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com>
> wrote:
>> I couldn't fix the problems with my weak ref implementation, so I
>> tweaked
>> Paul's fix a little to make it thread safe and better for inheritance.
>>
>> Anyway, the memory leak is gone and all unit tests pass after many
>> iterations.
>>
>> Are we ready for an RC2 and, hopefully, a quick release of version 1?
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jelly] RC2?
Posted by Hans Gilde <hg...@earthlink.net>.
Although, if JellyContext goes out of scope it should have the same effect.
-----Original Message-----
From: Paul Libbrecht [mailto:paul@activemath.org]
Sent: Friday, January 21, 2005 3:50 AM
To: Jakarta Commons Developers List
Subject: Re: [jelly] RC2?
As simple as that:
JellyContext.clear()
To be used, of course, from the same thread that ran the script !
paul
Le 21 janv. 05, à 02:49, Brett Porter a écrit :
>
> If there's a way to tell a context to clean up as it is going out of
> scope, that
> could definitely be added.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [jelly] RC2?
Posted by Paul Libbrecht <pa...@activemath.org>.
As simple as that:
JellyContext.clear()
To be used, of course, from the same thread that ran the script !
paul
Le 21 janv. 05, à 02:49, Brett Porter a écrit :
>
> If there's a way to tell a context to clean up as it is going out of
> scope, that
> could definitely be added.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jelly] RC2?
Posted by Brett Porter <br...@apache.org>.
You'd need to build Maven from CVS HEAD to use the latest version of Jelly (it
is currently set to beta-4, but I've tried it with RC2-SNAPSHOT as well - was
just waiting for the release to update).
maven multiproject:site for jelly-tags should do it.
IIRC, the project is disposed of, so the jellycontext's should also be (I mean
garbage collected here - nothing explicit is done). However, I haven't looked at
that in a year.
If there's a way to tell a context to clean up as it is going out of scope, that
could definitely be added.
- Brett
Quoting Hans Gilde <hg...@earthlink.net>:
> Could you give me an example of something that leaks? If Maven reuses the
> JellyContext, it'll still leak. Maven would have to add in a line to clear
> the Tag cache.
>
> -----Original Message-----
> From: Brett Porter [mailto:brett@apache.org]
> Sent: Thursday, January 20, 2005 6:12 AM
> To: Jakarta Commons Developers List
> Subject: Re: [jelly] RC2?
>
> Looks good in Maven 1.1 HEAD. Still leaking memory in multiproject
> sites, but I haven't done any recent work to isolate the cause of that.
> JSL remains the suspect, but nothing solid to back that.
>
> +1 on an RC2 release after standing bugs are fixed.
>
> - Brett
>
> Dion Gillard wrote:
>
> >Yep, I'm up for RC2 after some testing and then assuming no
> >showstoppers, a 1.0 straight after.
> >
> >
> >On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com> wrote:
> >
> >
> >>I couldn't fix the problems with my weak ref implementation, so I tweaked
> >>Paul's fix a little to make it thread safe and better for inheritance.
> >>
> >>Anyway, the memory leak is gone and all unit tests pass after many
> >>iterations.
> >>
> >>Are we ready for an RC2 and, hopefully, a quick release of version 1?
> >>
> >>
> >>Hans
> >>
> >>
> >>
> >>
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: [jelly] RC2?
Posted by Hans Gilde <hg...@earthlink.net>.
Could you give me an example of something that leaks? If Maven reuses the
JellyContext, it'll still leak. Maven would have to add in a line to clear
the Tag cache.
-----Original Message-----
From: Brett Porter [mailto:brett@apache.org]
Sent: Thursday, January 20, 2005 6:12 AM
To: Jakarta Commons Developers List
Subject: Re: [jelly] RC2?
Looks good in Maven 1.1 HEAD. Still leaking memory in multiproject
sites, but I haven't done any recent work to isolate the cause of that.
JSL remains the suspect, but nothing solid to back that.
+1 on an RC2 release after standing bugs are fixed.
- Brett
Dion Gillard wrote:
>Yep, I'm up for RC2 after some testing and then assuming no
>showstoppers, a 1.0 straight after.
>
>
>On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com> wrote:
>
>
>>I couldn't fix the problems with my weak ref implementation, so I tweaked
>>Paul's fix a little to make it thread safe and better for inheritance.
>>
>>Anyway, the memory leak is gone and all unit tests pass after many
>>iterations.
>>
>>Are we ready for an RC2 and, hopefully, a quick release of version 1?
>>
>>
>>Hans
>>
>>
>>
>>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [jelly] RC2?
Posted by Brett Porter <br...@apache.org>.
Looks good in Maven 1.1 HEAD. Still leaking memory in multiproject
sites, but I haven't done any recent work to isolate the cause of that.
JSL remains the suspect, but nothing solid to back that.
+1 on an RC2 release after standing bugs are fixed.
- Brett
Dion Gillard wrote:
>Yep, I'm up for RC2 after some testing and then assuming no
>showstoppers, a 1.0 straight after.
>
>
>On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com> wrote:
>
>
>>I couldn't fix the problems with my weak ref implementation, so I tweaked
>>Paul's fix a little to make it thread safe and better for inheritance.
>>
>>Anyway, the memory leak is gone and all unit tests pass after many
>>iterations.
>>
>>Are we ready for an RC2 and, hopefully, a quick release of version 1?
>>
>>
>>Hans
>>
>>
>>
>>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [jelly] RC2?
Posted by Dion Gillard <di...@gmail.com>.
Yep, I'm up for RC2 after some testing and then assuming no
showstoppers, a 1.0 straight after.
On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde <hg...@gmail.com> wrote:
> I couldn't fix the problems with my weak ref implementation, so I tweaked
> Paul's fix a little to make it thread safe and better for inheritance.
>
> Anyway, the memory leak is gone and all unit tests pass after many
> iterations.
>
> Are we ready for an RC2 and, hopefully, a quick release of version 1?
>
>
> Hans
>
>
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org