You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2024/03/06 10:27:46 UTC
[PR] CID1534729: txnbox - avoid copying object. [trafficserver]
brbzull0 opened a new pull request, #11134:
URL: https://github.com/apache/trafficserver/pull/11134
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CID1534729: txnbox - avoid copying object. [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #11134:
URL: https://github.com/apache/trafficserver/pull/11134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CID1534729: txnbox - avoid copying object. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on code in PR #11134:
URL: https://github.com/apache/trafficserver/pull/11134#discussion_r1514712329
##########
plugins/experimental/txn_box/plugin/src/text_block.cc:
##########
@@ -482,8 +482,8 @@ Mod_as_text_block::operator()(Context &ctx, Feature &feature)
{
Feature zret;
if (IndexFor(STRING) == feature.index()) {
- auto tag = std::get<IndexFor(STRING)>(feature); // get the name.
- zret = Ex_text_block::extract_block(ctx, tag);
+ auto const &tag = std::get<IndexFor(STRING)>(feature); // get the name.
+ zret = Ex_text_block::extract_block(ctx, tag);
Review Comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CID1534729: txnbox - avoid copying object. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11134:
URL: https://github.com/apache/trafficserver/pull/11134#issuecomment-1992502126
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org