You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/06/06 14:29:29 UTC

[GitHub] [incubator-yunikorn-k8shim] manirajv06 commented on a change in pull request #260: YUNIKORN-585: Create a Failing app state in shim side

manirajv06 commented on a change in pull request #260:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/260#discussion_r646140871



##########
File path: pkg/shim/scheduler_test.go
##########
@@ -132,7 +132,7 @@ partitions:
 
 	// wait for scheduling app and tasks
 	// verify app state
-	cluster.waitAndAssertApplicationState(t, appID, events.States().Application.Failed)
+	cluster.waitAndAssertApplicationState(t, appID, events.States().Application.Failing)

Review comment:
       Yes, correct. In case of app rejection, we should directly move the app to 'Failed' state. Handled it using appropriate state transition, rejected -> failed during fail application event. Please check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org