[GitHub] [airflow] mik-laj commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #6697: [AIRFLOW-6135] Extract DAG processing from SchedulerJob into separate class
URL: https://github.com/apache/airflow/pull/6697#discussion_r352892463
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -54,8 +54,9 @@
 from airflow.utils.state import State
 
 
-class DagFileProcessor(AbstractDagFileProcessor, LoggingMixin):
-    """Helps call SchedulerJob.process_file() in a separate process.
+class DagFileProcessorRunner(AbstractDagFileProcessorRunner, LoggingMixin):
 
 Review comment:
   I would like to separate classes that are executed in different threads and processes. New process = New class. This will greatly facilitate the understanding of the code. If we combine it, there will be a lot of methods available, but some intended only for execution from the main process level and others from the child process. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services