[GitHub] [zookeeper] cnauroth commented on a diff in pull request #1957: ZOOKEEPER-4644: update dependencies before release 3.6.4

[GitBox <gi...@apache.org>]

cnauroth commented on code in PR #1957:
URL: https://github.com/apache/zookeeper/pull/1957#discussion_r1044759918


##########
zookeeper-server/src/main/resources/NOTICE.txt:
##########
@@ -10,11 +10,14 @@ licensed under the Apache 2.0 license. The licensing terms
 for Airlift code can be found at:
 https://github.com/airlift/airlift/blob/master/LICENSE
 
+

Review Comment:
   Unnecessary blank line?



##########
pom.xml:
##########
@@ -347,26 +347,26 @@
     <surefire-forkcount>8</surefire-forkcount>
 
     <!-- dependency versions -->
-    <slf4j.version>1.7.35</slf4j.version>
-    <audience-annotations.version>0.5.0</audience-annotations.version>
+    <slf4j.version>1.7.36</slf4j.version>
+    <audience-annotations.version>0.12.0</audience-annotations.version>

Review Comment:
   Can this go to the newest version: 0.14.1?



##########
zookeeper-server/src/main/resources/NOTICE.txt:
##########
@@ -32,29 +35,112 @@ Base64 Encoder and Decoder, which can be obtained at:
   * HOMEPAGE:
     * http://iharder.sourceforge.net/current/java/base64/
 
-This product contains a modified version of 'JZlib', a re-implementation of
-zlib in pure Java, which can be obtained at:
+This product contains a modified portion of 'Webbit', an event based
+WebSocket and HTTP server, which can be obtained at:
+
+  * LICENSE:
+    * license/LICENSE.webbit.txt (BSD License)
+  * HOMEPAGE:
+    * https://github.com/joewalnes/webbit
+
+This product contains a modified portion of 'SLF4J', a simple logging
+facade for Java, which can be obtained at:
+
+  * LICENSE:
+    * license/LICENSE.slf4j.txt (MIT License)
+  * HOMEPAGE:
+    * https://www.slf4j.org/
 
+This product contains a modified portion of 'Apache Harmony', an open source

Review Comment:
   Can you please describe how you reviewed and decided what to add in NOTICE.txt? From a quick look, I'm unclear on how to draw the connection to some of these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org