You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 09:00:28 UTC

[GitHub] [thrift] emmenlau opened a new pull request #2114: Removed boost from compiler test, and deleted unused bincat.sh

emmenlau opened a new pull request #2114:
URL: https://github.com/apache/thrift/pull/2114


   This is a minor PR that removes the (now deprecated) boost dependency from the tests of Thrift compiler, and removes the (unused) script `bincat.sh`. I'm curious if the CI finds any problems...
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [xx] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] dcelasun commented on pull request #2114: Removed boost from compiler test, and deleted unused bincat.sh

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2114:
URL: https://github.com/apache/thrift/pull/2114#issuecomment-619047852


   LGTM and Travis is all green.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org