You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/06 02:40:49 UTC
[GitHub] [pulsar] hangc0276 commented on pull request #11880: [Broker] Remove redundant log guards for pulsar-broker
hangc0276 commented on pull request #11880:
URL: https://github.com/apache/pulsar/pull/11880#issuecomment-913295539
> Hi @codelipenghui @hangc0276 , could you also please review the code? Thanks a lot.
@tomscut Thanks for you contribution, if we remove the `log.isDebugEnabled()` check, it may cause more heap memory allocation and reduce performance.
https://logging.apache.org/log4j/log4j-2.3/performance.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org