You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Mikael Ståldal <mi...@apache.org> on 2017/07/30 19:51:22 UTC
Left to do for 2.9 release
* Ensure that Scala API documentation will be present on Log4j website.
* Fix broken JmsServer in log4j-server.
* Prepare release of logging-log4j-tools repo (if we want to do that).
Anything else?
Re: Left to do for 2.9 release
Posted by Matt Sicker <bo...@gmail.com>.
Provided I find time this week, I'd like to merge in the properties
simplification stuff I mentioned a little while ago.
On 30 July 2017 at 14:51, Mikael Ståldal <mi...@apache.org> wrote:
> * Ensure that Scala API documentation will be present on Log4j website.
>
> * Fix broken JmsServer in log4j-server.
>
> * Prepare release of logging-log4j-tools repo (if we want to do that).
>
> Anything else?
>
>
--
Matt Sicker <bo...@gmail.com>
Re: Left to do for 2.9 release
Posted by Gary Gregory <ga...@gmail.com>.
I just pushed an update that fixes the currently failing tests for JMS and
Flume.
Gary
On Sun, Jul 30, 2017 at 1:59 PM, Gary Gregory <ga...@gmail.com>
wrote:
> On Sun, Jul 30, 2017 at 1:48 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> * I think the new logic to avoid logging calls blowing up
>> (ConcurrentModificationException) circumvents the ignoreExceptions
>> settings on appenders.
>>
>
> If wonder if we should change the org.apache.logging.log4j.spi.
> AbstractLogger.tryLogMessage(String, Level, Marker, Message, Throwable)
> -- a new method called from logMessageSafely -- such that if an
> AppenderLoggingException is thrown it is always surfaced.
>
> The lower guts would only throw AppenderLoggingException as allowed by
> ignoreExceptions. AppenderLoggingException should not be throws in the guts
> of appenders, let IOExceptions and other trickle up and be handled per
> ignoreExceptions.
>
> Thoughts?
>
> Gary
>
>
>
>> * "Fix broken JmsServer in log4j-server": I'm not that but that's how I
>> discovered the above.
>>
>> * "Prepare release of logging-log4j-tools repo (if we want to do that)":
>> For my buck, I'd prefer to see the log4j-server module in the main repo.
>>
>> Gary
>>
>> On Sun, Jul 30, 2017 at 12:51 PM, Mikael Ståldal <mi...@apache.org>
>> wrote:
>>
>>> * Ensure that Scala API documentation will be present on Log4j website.
>>>
>>> * Fix broken JmsServer in log4j-server.
>>>
>>> * Prepare release of logging-log4j-tools repo (if we want to do that).
>>>
>>> Anything else?
>>>
>>>
>>
>
Re: Left to do for 2.9 release
Posted by Remko Popma <re...@gmail.com>.
> On Jul 31, 2017, at 5:59, Gary Gregory <ga...@gmail.com> wrote:
>
> On Sun, Jul 30, 2017 at 1:48 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> * I think the new logic to avoid logging calls blowing up (
>> ConcurrentModificationException) circumvents the ignoreExceptions
>> settings on appenders.
>>
>
> If wonder if we should change the
> org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(String, Level,
> Marker, Message, Throwable) -- a new method called from logMessageSafely --
> such that if an AppenderLoggingException is thrown it is always surfaced.
>
> The lower guts would only throw AppenderLoggingException as allowed by
> ignoreExceptions. AppenderLoggingException should not be throws in the guts
> of appenders, let IOExceptions and other trickle up and be handled per
> ignoreExceptions.
>
> Thoughts?
I replied on the https://issues.apache.org/jira/browse/LOG4J2-1990 ticket to keep discussions on this topic in one place.
>
> Gary
>
>
>
>> * "Fix broken JmsServer in log4j-server": I'm not that but that's how I
>> discovered the above.
>>
>> * "Prepare release of logging-log4j-tools repo (if we want to do that)":
>> For my buck, I'd prefer to see the log4j-server module in the main repo.
>>
>> Gary
>>
>>> On Sun, Jul 30, 2017 at 12:51 PM, Mikael Ståldal <mi...@apache.org> wrote:
>>>
>>> * Ensure that Scala API documentation will be present on Log4j website.
>>>
>>> * Fix broken JmsServer in log4j-server.
>>>
>>> * Prepare release of logging-log4j-tools repo (if we want to do that).
>>>
>>> Anything else?
>>>
>>>
>>
Re: Left to do for 2.9 release
Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Jul 30, 2017 at 1:48 PM, Gary Gregory <ga...@gmail.com>
wrote:
> * I think the new logic to avoid logging calls blowing up (
> ConcurrentModificationException) circumvents the ignoreExceptions
> settings on appenders.
>
If wonder if we should change the
org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(String, Level,
Marker, Message, Throwable) -- a new method called from logMessageSafely --
such that if an AppenderLoggingException is thrown it is always surfaced.
The lower guts would only throw AppenderLoggingException as allowed by
ignoreExceptions. AppenderLoggingException should not be throws in the guts
of appenders, let IOExceptions and other trickle up and be handled per
ignoreExceptions.
Thoughts?
Gary
> * "Fix broken JmsServer in log4j-server": I'm not that but that's how I
> discovered the above.
>
> * "Prepare release of logging-log4j-tools repo (if we want to do that)":
> For my buck, I'd prefer to see the log4j-server module in the main repo.
>
> Gary
>
> On Sun, Jul 30, 2017 at 12:51 PM, Mikael Ståldal <mi...@apache.org> wrote:
>
>> * Ensure that Scala API documentation will be present on Log4j website.
>>
>> * Fix broken JmsServer in log4j-server.
>>
>> * Prepare release of logging-log4j-tools repo (if we want to do that).
>>
>> Anything else?
>>
>>
>
Re: Left to do for 2.9 release
Posted by Mikael Ståldal <mi...@apache.org>.
Me too. I think it's to much bureaucratic overhead with a new repo.
On 2017-07-30 22:48, Gary Gregory wrote:
> * "Prepare release of logging-log4j-tools repo (if we want to do that)":
> For my buck, I'd prefer to see the log4j-server module in the main repo.
>
> Gary
Re: Left to do for 2.9 release
Posted by Gary Gregory <ga...@gmail.com>.
* I think the new logic to avoid logging calls blowing up
(ConcurrentModificationException) circumvents the ignoreExceptions settings
on appenders.
* "Fix broken JmsServer in log4j-server": I'm not that but that's how I
discovered the above.
* "Prepare release of logging-log4j-tools repo (if we want to do that)":
For my buck, I'd prefer to see the log4j-server module in the main repo.
Gary
On Sun, Jul 30, 2017 at 12:51 PM, Mikael Ståldal <mi...@apache.org> wrote:
> * Ensure that Scala API documentation will be present on Log4j website.
>
> * Fix broken JmsServer in log4j-server.
>
> * Prepare release of logging-log4j-tools repo (if we want to do that).
>
> Anything else?
>
>