You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/09/17 07:44:01 UTC
Review Request 71494: Removed documentation on cquery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71494/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benno Evers, and Till Toenshoff.
Repository: mesos
Description
-------
Cquery is not developed anymore and being replaced by larger LSP
implementation such as clangd. This patch completely removes any
cquery-related documentation instead of updating it to use e.g., clangd.
This is because any documentation related to setting up a LSP pipeline
would be almost exclusively generic to a CMake C++ project and not
specific to Mesos.
Diffs
-----
docs/cquery.md b893bc522561306a2cdf15e1c1876108ec8d329c
docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd
Diff: https://reviews.apache.org/r/71494/diff/1/
Testing
-------
Test-rendered the documentation
Thanks,
Benjamin Bannier
Re: Review Request 71494: Removed documentation on cquery.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71494/#review217780
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71494]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 17, 2019, 7:44 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71494/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2019, 7:44 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benno Evers, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cquery is not developed anymore and being replaced by larger LSP
> implementation such as clangd. This patch completely removes any
> cquery-related documentation instead of updating it to use e.g., clangd.
> This is because any documentation related to setting up a LSP pipeline
> would be almost exclusively generic to a CMake C++ project and not
> specific to Mesos.
>
>
> Diffs
> -----
>
> docs/cquery.md b893bc522561306a2cdf15e1c1876108ec8d329c
> docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd
>
>
> Diff: https://reviews.apache.org/r/71494/diff/1/
>
>
> Testing
> -------
>
> Test-rendered the documentation
>
>
> Thanks,
>
> Benjamin Bannier
>
>