You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 09:54:45 UTC

[GitHub] [flink] pnowojski opened a new pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

pnowojski opened a new pull request #12244:
URL: https://github.com/apache/flink/pull/12244


   Please take a look at the individual commit messages. First commit is from another PR FLINK-17780.
   
   ## Verifying this change
   
   This PR fixes test failures with enabled unaligned checkpoints by default.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   * 7fa2068a283b9471384248c1bf301e3d406b5f48 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951) 
   * d0d2042ea348654430863ccb51084c30714d8a47 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959",
       "triggerID" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7fa2068a283b9471384248c1bf301e3d406b5f48 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951) 
   * d0d2042ea348654430863ccb51084c30714d8a47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630815992


   Test failure is unrelated and fixed on more recent master by some commit (don't know which)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   * 7fa2068a283b9471384248c1bf301e3d406b5f48 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   * 7fa2068a283b9471384248c1bf301e3d406b5f48 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #12244:
URL: https://github.com/apache/flink/pull/12244


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959",
       "triggerID" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d0d2042ea348654430863ccb51084c30714d8a47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on a change in pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #12244:
URL: https://github.com/apache/flink/pull/12244#discussion_r428043879



##########
File path: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
##########
@@ -300,7 +300,8 @@ public void testCheckpointingCustomKvStateJobWithCustomClassLoader() throws IOEx
 	 */
 	@Test
 	public void testDisposeSavepointWithCustomKvState() throws Exception {
-		ClusterClient<?> clusterClient = new MiniClusterClient(new Configuration(), miniClusterResource.getMiniCluster());
+		Configuration configuration = new Configuration();

Review comment:
       nit: I guess it was extracted to disable unaligned checkpoints, but then CLI argument was used; so this variable can be inlined back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630717651


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3dcc9233af810b8be408665c0083fab404a2dea5 (Tue May 19 09:57:35 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630723509


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833",
       "triggerID" : "3dcc9233af810b8be408665c0083fab404a2dea5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951",
       "triggerID" : "7fa2068a283b9471384248c1bf301e3d406b5f48",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959",
       "triggerID" : "d0d2042ea348654430863ccb51084c30714d8a47",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3dcc9233af810b8be408665c0083fab404a2dea5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1833) 
   * 7fa2068a283b9471384248c1bf301e3d406b5f48 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1951) 
   * d0d2042ea348654430863ccb51084c30714d8a47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12244: [FLINK-17258][network] Fix couple of ITCases that were failing with enabled unaligned checkpoints

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12244:
URL: https://github.com/apache/flink/pull/12244#issuecomment-630717651


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d0d2042ea348654430863ccb51084c30714d8a47 (Fri Oct 16 10:53:29 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org