[jira] [Comment Edited] (BIGTOP-2458) Add option to disable IP hostname checking for DataNode registration

["Olaf Flebbe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334314#comment-15334314 ] 

Olaf Flebbe edited comment on BIGTOP-2458 at 6/16/16 6:01 PM:
--------------------------------------------------------------

- LGTM +1 -

No handling of default value os not ok.

in {{init.pp}} in the argument list the value should have a default value = "true", Please do not set default values in cluster.yaml.

if {{hdfs-site.xml}} the value should be tested to be different from undef before inserting the sniplet.




was (Author: oflebbe):
LGTM +1

> Add option to disable IP hostname checking for DataNode registration
> --------------------------------------------------------------------
>
>                 Key: BIGTOP-2458
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2458
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 1.1.0
>            Reporter: Cory Johns
>            Assignee: Cory Johns
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch
>
>
> Add a puppet config option to control ip_hostname_check.  If deploying on a cloud that does not provide reverse DNS service, the DataNode registration to the NameNode will fail.  Exposing this option allows deployments to work around this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)