You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rags22489664 <gi...@git.apache.org> on 2015/10/01 11:42:27 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8929
GitHub user rags22489664 opened a pull request:
https://github.com/apache/cloudstack/pull/904
CLOUDSTACK-8929
After a load balancer rule is created and if another VM is assigned to it, it still shows up in the list of VMs that can be assigned to it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rags22489664/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #904
----
commit 4f79c148e3545eb8dc4c2bf78c646a19bc55abfc
Author: ramamurtis <ra...@citrix.com>
Date: 2015-10-01T09:39:57Z
CLOUDSTACK-8929: After a load balancer rule is created and if another VM is assigned to it, it still shows up in the list of VMs that can be assigned to it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144708545
The original bug report is also a bit vague:
```
After a load balancer rule is created and if another VM is assigned to it,
it still shows up in the list of VMs that can be assigned to it
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144703027
Okay. Then this Pr should be closed without merge.
@rags22489664, could you please close it?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144703355
@wilderrodrigues why do you want the PR to get closed ? Can't this be amended to provide the proper fix ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144700407
@wilderrodrigues Aha, yes. Didn't think of that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144704442
Hi @runseb
If one tries to add the same rule for the same VM, ACS will say it cannot be done because the rule for that given VM already exists.
If one doesn't want to see the 2 VMs on the list, instead of getting the error message after clicking "ok", the fix would be something like this:
* Read the public/private ports entered and the VM info of those ports. Based on that, show the list with.
* If the ports are different, all VMs in the network should be displayed.
If it's his intention to have the feature as described above, then he can amend it. But that would be an improvement, not a bug fix.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by rags22489664 <gi...@git.apache.org>.
Github user rags22489664 closed the pull request at:
https://github.com/apache/cloudstack/pull/904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by rags22489664 <gi...@git.apache.org>.
Github user rags22489664 commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-147951735
Sorry for the delayed response, I was attending the conference in Dublin. I will make appropriate fix and will open another pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144697940
Seems like a very trivial fix to me. LGTM based on the code I see
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144700051
Hi @rags22489664 and @wido,
I think this fix will not work properly. For example:
1. Create 2 VMs on an isolated networkl
2. Acquire a new Public IP
3. Add a firewall rule to port 22
4. Add a firewall rule to port 80
5. Add a Load Balancing rule to one of the VMs for port 22
6. Add a Load Balancing rule to one of the VMs for port 80
See what I mean? I might want to see both VMs on the list in order to decide which one should have the rule assigned to.
Will your change remove the first VM (assigned to port 22) form the list?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-145662123
@rags22489664 any comments based on the reviews ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8929
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144703027
Okay. Then this Pr should be closed without merge.
@rags22489664, could you please close it?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---