You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2024/01/08 01:40:00 UTC

[jira] [Updated] (HDDS-10041) Do not start the daemon inside the OzoneManagerDoubleBuffer constructor

     [ https://issues.apache.org/jira/browse/HDDS-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz-wo Sze updated HDDS-10041:
------------------------------
    Description: 
It is generally a bad practice to start a thread inside a constructor; see [https://stackoverflow.com/questions/11834173/why-shouldnt-i-use-thread-start-in-the-constructor-of-my-class]

Also, quite a few tests (such as TestOzoneManagerDoubleBuffer) has to stop the daemon in order to eliminate the race condition in the very beginning.

  was:
It is generally a bad practice to start a thread inside a constructor; see https://stackoverflow.com/questions/11834173/why-shouldnt-i-use-thread-start-in-the-constructor-of-my-class

Also, quite a few tests (such as TestOzoneManagerDoubleBuffer) has to stop the daemon till to eliminate the race condition in the very beginning.


> Do not start the daemon inside the OzoneManagerDoubleBuffer constructor
> -----------------------------------------------------------------------
>
>                 Key: HDDS-10041
>                 URL: https://issues.apache.org/jira/browse/HDDS-10041
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: OM
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>
> It is generally a bad practice to start a thread inside a constructor; see [https://stackoverflow.com/questions/11834173/why-shouldnt-i-use-thread-start-in-the-constructor-of-my-class]
> Also, quite a few tests (such as TestOzoneManagerDoubleBuffer) has to stop the daemon in order to eliminate the race condition in the very beginning.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org