You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/15 02:55:07 UTC
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #4751: Fix 4671
tristaZero commented on a change in pull request #4751: Fix 4671
URL: https://github.com/apache/incubator-shardingsphere/pull/4751#discussion_r392636480
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/segment/definition/ColumnPositionAssert.java
##########
@@ -47,15 +47,19 @@ public static void assertIs(final SQLCaseAssertContext assertContext, final Colu
if (null != actual.getColumnName()) {
columnname = actual.getColumnName().getQualifiedName();
}
Review comment:
It is better to extract a function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services