You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/04 11:14:27 UTC
Review Request 62767: SENTRY-1973 - Use KafkaPrivilegeModel to
retrieve Kafka validators
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62767/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1973
https://issues.apache.org/jira/browse/SENTRY-1973
Repository: sentry
Description
-------
This task is to use the KafkaPrivilegeModel to retrieve the Kafka validators instead of hard-coding them in KafkaTSentryPrivilegeConverter.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java 688bc9e4
Diff: https://reviews.apache.org/r/62767/diff/1/
Testing
-------
Tested the SentryShell works ok.
Thanks,
Colm O hEigeartaigh
Re: Review Request 62767: SENTRY-1973 - Use KafkaPrivilegeModel to
retrieve Kafka validators
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62767/#review187099
-----------------------------------------------------------
Ship it!
The patch looks good.
Thanks.
- Sergio Pena
On Oct. 4, 2017, 12:04 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62767/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2017, 12:04 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1973
> https://issues.apache.org/jira/browse/SENTRY-1973
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This task is to use the KafkaPrivilegeModel to retrieve the Kafka validators instead of hard-coding them in KafkaTSentryPrivilegeConverter.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java 688bc9e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConverter.java 92c6c599
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 183e83d3
>
>
> Diff: https://reviews.apache.org/r/62767/diff/2/
>
>
> Testing
> -------
>
> Tested the SentryShell works ok.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 62767: SENTRY-1973 - Use KafkaPrivilegeModel to
retrieve Kafka validators
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62767/
-----------------------------------------------------------
(Updated Oct. 4, 2017, 12:04 p.m.)
Review request for sentry.
Bugs: SENTRY-1973
https://issues.apache.org/jira/browse/SENTRY-1973
Repository: sentry
Description
-------
This task is to use the KafkaPrivilegeModel to retrieve the Kafka validators instead of hard-coding them in KafkaTSentryPrivilegeConverter.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java 688bc9e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConverter.java 92c6c599
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 183e83d3
Diff: https://reviews.apache.org/r/62767/diff/2/
Changes: https://reviews.apache.org/r/62767/diff/1-2/
Testing
-------
Tested the SentryShell works ok.
Thanks,
Colm O hEigeartaigh