You are viewing a plain text version of this content. The canonical link for it is here.

Posted to fop-dev@xmlgraphics.apache.org by Chris Bowditch <bo...@hotmail.com> on 2013/03/05 16:22:34 UTC

Revision 1435241 for FOP-2191 introduces a Findbugs warning

Specifically:

Code 	Warning
EI2 
org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, 
String, String, String, int, int[], int[][], ScriptContextTester) may 
expose internal representation by storing an externally mutable object 
into GlyphPositioningState.adjustments

	

Bug type EI_EXPOSE_REP2 (click for details) <#EI_EXPOSE_REP2>
In class org.apache.fop.complexscripts.fonts.GlyphPositioningState
In method 
org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, 
String, String, String, int, int[], int[][], ScriptContextTester)
Field org.apache.fop.complexscripts.fonts.GlyphPositioningState.adjustments
Local variable named adjustments
At GlyphPositioningState.java:[line 97]


EI2 
org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, 
String, String, String, int, int[], int[][], ScriptContextTester) may 
expose internal representation by storing an externally mutable object 
into GlyphPositioningState.widths


I would appreciate it if the developer responsible could address this 
warning.

Thanks,

Chris

Re: Revision 1435241 for FOP-2191 introduces a Findbugs warning

Posted by Chris Bowditch <bo...@hotmail.com>.

Thanks Glenn. I overlooked the exclude file.

Chris

On 05/03/2013 16:10, Glenn Adams wrote:
> It was already fixed in https://issues.apache.org/jira/browse/FOP-2192 
> (rev 1435270). :)
>
> On Tue, Mar 5, 2013 at 8:22 AM, Chris Bowditch 
> <bowditch_chris@hotmail.com <ma...@hotmail.com>> wrote:
>
>     Specifically:
>
>     Code    Warning
>     EI2
>     org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence,
>     String, String, String, int, int[], int[][], ScriptContextTester)
>     may expose internal representation by storing an externally
>     mutable object into GlyphPositioningState.adjustments
>
>
>
>     Bug type EI_EXPOSE_REP2 (click for details) <#EI_EXPOSE_REP2>
>     In class org.apache.fop.complexscripts.fonts.GlyphPositioningState
>     In method
>     org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence,
>     String, String, String, int, int[], int[][], ScriptContextTester)
>     Field
>     org.apache.fop.complexscripts.fonts.GlyphPositioningState.adjustments
>     Local variable named adjustments
>     At GlyphPositioningState.java:[line 97]
>
>
>     EI2
>     org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence,
>     String, String, String, int, int[], int[][], ScriptContextTester)
>     may expose internal representation by storing an externally
>     mutable object into GlyphPositioningState.widths
>
>
>     I would appreciate it if the developer responsible could address
>     this warning.
>
>     Thanks,
>
>     Chris
>
>

Re: Revision 1435241 for FOP-2191 introduces a Findbugs warning

Posted by Glenn Adams <gl...@skynav.com>.

It was already fixed in
https://issues.apache.org/jira/browse/FOP-2192(rev 1435270). :)

On Tue, Mar 5, 2013 at 8:22 AM, Chris Bowditch
<bo...@hotmail.com>wrote:

> Specifically:
>
> Code    Warning
> EI2 org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence,
> String, String, String, int, int[], int[][], ScriptContextTester) may
> expose internal representation by storing an externally mutable object into
> GlyphPositioningState.**adjustments
>
>
>
> Bug type EI_EXPOSE_REP2 (click for details) <#EI_EXPOSE_REP2>
> In class org.apache.fop.complexscripts.**fonts.GlyphPositioningState
> In method org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence,
> String, String, String, int, int[], int[][], ScriptContextTester)
> Field org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**
> adjustments
> Local variable named adjustments
> At GlyphPositioningState.java:[**line 97]
>
>
> EI2 org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence,
> String, String, String, int, int[], int[][], ScriptContextTester) may
> expose internal representation by storing an externally mutable object into
> GlyphPositioningState.widths
>
>
> I would appreciate it if the developer responsible could address this
> warning.
>
> Thanks,
>
> Chris
>