You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2021/04/18 11:44:30 UTC
[impala] 02/02: IMPALA-10532:
TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit fdb6a4e264ad3f156a76c4fc01d4c1b8f9b39189
Author: Qifan Chen <qc...@cloudera.com>
AuthorDate: Thu Apr 8 13:08:22 2021 -0400
IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This change disables the overlap min/max filter test for hdfs in
erasure coding, due to the query plan change (from 3-node scan to
2-node scan) which splits the row groups among scan nodes differently.
The SkipIfEC class in test harness skip.py is enhanced with a new
skip reason 'different_scan_split' to facilitate this action.
Testing:
1. Ran unit tests;
2. Ran core tests.
Change-Id: I527de530f7db1ce959e7ef2ae3ced18677221c9f
Reviewed-on: http://gerrit.cloudera.org:8080/17289
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/common/skip.py | 2 ++
tests/query_test/test_runtime_filters.py | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/common/skip.py b/tests/common/skip.py
index 6acef78..bde0f22 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -215,6 +215,8 @@ class SkipIfEC:
contain_full_explain = pytest.mark.skipif(IS_EC, reason="Contain full explain output "
"for hdfs tables.")
different_schedule = pytest.mark.skipif(IS_EC, reason="Query is scheduled differently.")
+ different_scan_split = pytest.mark.skipif(IS_EC, reason="Scan split of row "
+ "groups for Parquet tables created in EC mode is different.")
class SkipIfDockerizedCluster:
diff --git a/tests/query_test/test_runtime_filters.py b/tests/query_test/test_runtime_filters.py
index 2f9b6b6..61f63ce 100644
--- a/tests/query_test/test_runtime_filters.py
+++ b/tests/query_test/test_runtime_filters.py
@@ -26,6 +26,7 @@ from tests.common.environ import build_flavor_timeout
from tests.common.environ import ImpalaTestClusterProperties
from tests.common.impala_cluster import ImpalaCluster
from tests.common.impala_test_suite import ImpalaTestSuite
+from tests.common.skip import SkipIfEC
from tests.common.skip import SkipIfLocal, SkipIfIsilon
from tests.common.test_dimensions import add_exec_option_dimension
from tests.common.test_vector import ImpalaTestDimension
@@ -266,6 +267,7 @@ class TestMinMaxFilters(ImpalaTestSuite):
assert cursor.fetchall() == [(len(matching_vals) + 2,)]
+@SkipIfEC.different_scan_split
@SkipIfLocal.multiple_impalad
class TestOverlapMinMaxFilters(ImpalaTestSuite):
@classmethod