You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/13 13:00:14 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #1699: MapArrayReader Does Not Understand Nesting
tustvold opened a new issue, #1699:
URL: https://github.com/apache/arrow-rs/issues/1699
**Describe the bug**
The logic within MapArrayReader will not work if the MapArray is itself nested, in particular:
* It does not expose the def_level / rep_levels of its children
* It assumes that a repetition level of 0 corresponds to a new map entry
**To Reproduce**
A nullable StructArray with a child MapArray will likely result in an error, similarly a ListArray with a child MapArray will likely error
**Expected behavior**
This should be properly supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #1699: MapArrayReader Does Not Understand Nesting
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #1699:
URL: https://github.com/apache/arrow-rs/issues/1699#issuecomment-1159362165
Hi @frolovdev. I'm afraid I'm away from a computer for the next few days, but taking a cursory look, lines like
```
let entry_len = rep_levels.iter().filter(|level| **level == 0).count();
```
Are not able to correctly handle the case of a MapArrayReader inside another list, as it starts a new run when the repetition level is 0, as opposed to the repetition level of the map array (which will only be 0 if it is at the root).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] frolovdev commented on issue #1699: MapArrayReader Does Not Understand Nesting
Posted by GitBox <gi...@apache.org>.
frolovdev commented on issue #1699:
URL: https://github.com/apache/arrow-rs/issues/1699#issuecomment-1159147393
@tustvold maybe I get your idea wrong but I can't reproduce it in any ways
```
message table {
repeated group my_group_map {
REQUIRED BYTE_ARRAY kek;
optional group map (MAP) {
repeated group key_value {
REQUIRED BYTE_ARRAY key;
OPTIONAL group nested_map (MAP) {
repeated group key_value {
REQUIRED BYTE_ARRAY key;
REQUIRED BYTE_ARRAY value;
}
}
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #1699: MapArrayReader Does Not Understand Nesting
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #1699: MapArrayReader Does Not Understand Nesting
URL: https://github.com/apache/arrow-rs/issues/1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org