You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Kalle Korhonen (JIRA)" <ji...@apache.org> on 2009/08/26 04:38:59 UTC
[jira] Created: (SHIRO-90)
org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is
unreliable
org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is unreliable
--------------------------------------------------------------------------------------
Key: SHIRO-90
URL: https://issues.apache.org/jira/browse/SHIRO-90
Project: Shiro
Issue Type: Test
Components: Session Management
Affects Versions: 0.9
Environment: Jdk 1.6, winxp on dual core i386 Lenovo w500
Reporter: Kalle Korhonen
Priority: Minor
Fix For: 1.0
testGlobalTimeout in DefaultSessionManagerTest frequently fails on the first assert (when session is supposed to be valid), but not every time. If I increase GlobalSessionTimeout to 200ms from 125ms I couldn't make it fail. I didn't dig deep enough to find out whether the problem is indicative of a bug in the application test or just not well-constructed test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHIRO-90)
org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is
unreliable
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Les Hazlewood resolved SHIRO-90.
--------------------------------
Resolution: Fixed
A better (non-sleep based) test implementation was committed to rev. 808603
> org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is unreliable
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-90
> URL: https://issues.apache.org/jira/browse/SHIRO-90
> Project: Shiro
> Issue Type: Test
> Components: Session Management
> Affects Versions: 0.9
> Environment: Jdk 1.6, winxp on dual core i386 Lenovo w500
> Reporter: Kalle Korhonen
> Priority: Minor
> Fix For: 1.0
>
>
> testGlobalTimeout in DefaultSessionManagerTest frequently fails on the first assert (when session is supposed to be valid), but not every time. If I increase GlobalSessionTimeout to 200ms from 125ms I couldn't make it fail. I didn't dig deep enough to find out whether the problem is indicative of a bug in the application test or just not well-constructed test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-90)
org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is
unreliable
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748455#action_12748455 ]
Les Hazlewood commented on SHIRO-90:
------------------------------------
Yep, this is a less than ideal test - it uses thread sleep to simulate passing of time, and for the low millisecond numbers, the result could vary depending on runtime environment. It would be ideal to create a test which simulates session timeout conditions rather than relying on thread sleeping. I'll leave this issue open until we can do that.
> org.apache.shiro.session.mgt.DefaultSessionManagerTest.testGlobalTimeout is unreliable
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-90
> URL: https://issues.apache.org/jira/browse/SHIRO-90
> Project: Shiro
> Issue Type: Test
> Components: Session Management
> Affects Versions: 0.9
> Environment: Jdk 1.6, winxp on dual core i386 Lenovo w500
> Reporter: Kalle Korhonen
> Priority: Minor
> Fix For: 1.0
>
>
> testGlobalTimeout in DefaultSessionManagerTest frequently fails on the first assert (when session is supposed to be valid), but not every time. If I increase GlobalSessionTimeout to 200ms from 125ms I couldn't make it fail. I didn't dig deep enough to find out whether the problem is indicative of a bug in the application test or just not well-constructed test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.