You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/18 02:46:50 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15836: [feature wip](multi catalog)Support iceberg schema evolution.
github-actions[bot] commented on code in PR #15836:
URL: https://github.com/apache/doris/pull/15836#discussion_r1073042231
##########
be/test/vec/exec/parquet/parquet_reader_test.cpp:
##########
@@ -114,7 +115,7 @@ TEST_F(ParquetReaderTest, normal) {
runtime_state.init_mem_trackers();
std::unordered_map<std::string, ColumnValueRangeType> colname_to_value_range;
- p_reader->init_reader(column_names, nullptr, nullptr);
+ p_reader->init_reader(column_names, col_id_name_map, nullptr, nullptr);
Review Comment:
warning: no viable conversion from 'std::unordered_map<int, std::string>' (aka 'unordered_map<int, basic_string<char>>') to 'std::unordered_map<std::string, ColumnValueRangeType> *' (aka 'unordered_map<basic_string<char>, variant<ColumnValueRange<TYPE_TINYINT>, ColumnValueRange<TYPE_SMALLINT>, ColumnValueRange<TYPE_INT>, ColumnValueRange<TYPE_BIGINT>, ColumnValueRange<TYPE_LARGEINT>, ColumnValueRange<TYPE_CHAR>, ColumnValueRange<TYPE_VARCHAR>, ColumnValueRange<TYPE_STRING>, ColumnValueRange<TYPE_DATE>, ColumnValueRange<TYPE_DATEV2>, ColumnValueRange<TYPE_DATETIME>, ColumnValueRange<TYPE_DATETIMEV2>, ColumnValueRange<TYPE_DECIMALV2>, ColumnValueRange<TYPE_BOOLEAN>, ColumnValueRange<TYPE_HLL>, ColumnValueRange<TYPE_DECIMAL32>, ColumnValueRange<TYPE_DECIMAL64>, ColumnValueRange<TYPE_DECIMAL128I>>> *') [clang-diagnostic-error]
```cpp
p_reader->init_reader(column_names, col_id_name_map, nullptr, nullptr);
^
```
**be/src/vec/exec/format/parquet/vparquet_reader.h:72:** passing argument to parameter 'colname_to_value_range' here
```cpp
std::unordered_map<std::string, ColumnValueRangeType>* colname_to_value_range,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org