You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2024/09/12 16:12:15 UTC
[PR] style(chart design): clarify ambiguously named "sort by" field [superset]
sfirke opened a new pull request, #30254:
URL: https://github.com/apache/superset/pull/30254
### SUMMARY
Users sometimes don't understand the field with the ambiguous name "Sort By". For instance, in https://github.com/apache/superset/issues/30238 someone expected it would govern the order of the bars along the axis. Other times they think it will sort the order of series on a dimension field. These two kinds of sorting have more clearly-named fields; this "Sort By" sorts the underlying data which is relevant only in the case where a row limit or series limit is reached.
This PR renames that field from "Sort By" to "Data Limit Sort By".
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE**
**AFTER**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2359231437
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2351681777
> I like `Query Sort By`, that makes it clear it's a backend thing.
Sort Query By?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2359008622
This one Cypress test keeps failing with a vague error message. Is there a way to tell if there is a Cypress test that is failing because this label changed or if it's just flaky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2359014714
@sfirke This is a known problem with Cypress that is currently being investigated. For now, you just need to keep re-triggering that job until you get lucky 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2346823761
I'm also not sure about Data Limit Sort By... Maybe `Data Sort By` or `Query Sort By`? I'm ok with you don't find a better name for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #30254:
URL: https://github.com/apache/superset/pull/30254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2353144099
@sfirke Ephemeral environment spinning up at http://44.242.227.133:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2346816278
I hear you @rusackas, I went back and forth... of the Copilot suggestions, the other contenders I liked were "Pre-Render Sort By" and "Truncation Sort By" -- do you like one of those better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2353119040
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2353241385
I updated the label text to `Sort query by`.
And I updated the tooltip. This sorts the query result which affects data download + drilling so doesn't matter only in the case that a limit is reached -- another reason that your suggestions are better than the original idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] style(explore): clarify ambiguously named "sort by" field [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #30254:
URL: https://github.com/apache/superset/pull/30254#issuecomment-2346842696
I like `Query Sort By`, that makes it clear it's a backend thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org