You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by bu...@apache.org on 2014/07/03 22:37:20 UTC
svn commit: r914935 - in /websites/staging/mahout/trunk/content: ./
developers/how-to-contribute.html
Author: buildbot
Date: Thu Jul 3 20:37:20 2014
New Revision: 914935
Log:
Staging update by buildbot for mahout
Modified:
websites/staging/mahout/trunk/content/ (props changed)
websites/staging/mahout/trunk/content/developers/how-to-contribute.html
Propchange: websites/staging/mahout/trunk/content/
------------------------------------------------------------------------------
--- cms:source-revision (original)
+++ cms:source-revision Thu Jul 3 20:37:20 2014
@@ -1 +1 @@
-1607741
+1607745
Modified: websites/staging/mahout/trunk/content/developers/how-to-contribute.html
==============================================================================
--- websites/staging/mahout/trunk/content/developers/how-to-contribute.html (original)
+++ websites/staging/mahout/trunk/content/developers/how-to-contribute.html Thu Jul 3 20:37:20 2014
@@ -340,7 +340,7 @@ with two exceptions:<ul>
incorporate other's suggestions into into your changes if you think they're reasonable. Finally, remember that even changes that are not committed are useful to the community.</p>
<p><a name="HowToContribute-UnitTests"></a></p>
<h4 id="unit-tests">Unit Tests</h4>
-<p>Please make sure that all unit tests succeed before creating your pull request.</p>
+<p>Please make sure that all unit tests succeed before creating your Pull Request.</p>
<p>Run <em>mvn clean test</em>, if you see <em>BUILD SUCCESSFUL</em> after the tests have finished, all is ok, but if you see <em>BUILD FAILED</em>,
please carefully read the errors messages and check your code.</p>
<h4 id="dos-and-donts">Do's and Don'ts</h4>
@@ -362,7 +362,7 @@ subversion to figure out what's changed
<p><a name="HowToContribute-Review/ImproveExistingPatches"></a></p>
<h2 id="reviewimprove-existing-pull-requests">Review/Improve Existing Pull Requests</h2>
<p>If there's a JIRA issue that already has a Pull Request with changes that you think are really good, and works well for you -- please add a comment saying so. If there's room
-for improvement (more tests, better javadocs, etc...) then make the changes and add a comment about them. If a lot of people review a Pull Request and give it a
+for improvement (more tests, better javadocs, etc...) then make the changes on your GitHub branch and add a comment about them. If a lot of people review a Pull Request and give it a
thumbs up, that's a good sign for committers when deciding if it's worth spending time to review it -- and if other people have already put in
effort to improve the docs/tests for an issue, that helps even more.</p>
<p>For more information see <a href="http://mahout.apache.org/developers/github.html">Handling GitHub PRs</a>.</p>