You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-commits@lucene.apache.org by us...@apache.org on 2010/02/04 10:17:12 UTC
svn commit: r906411 -
/lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java
Author: uschindler
Date: Thu Feb 4 09:16:56 2010
New Revision: 906411
URL: http://svn.apache.org/viewvc?rev=906411&view=rev
Log:
LUCENE-2247: Add missing test for stringIterator() after clover report studies...
Modified:
lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java
Modified: lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java
URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java?rev=906411&r1=906410&r2=906411&view=diff
==============================================================================
--- lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java (original)
+++ lucene/java/trunk/src/test/org/apache/lucene/analysis/TestCharArraySet.java Thu Feb 4 09:16:56 2010
@@ -23,6 +23,7 @@
import java.util.HashSet;
import java.util.List;
import java.util.Set;
+import java.util.Iterator;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.Version;
@@ -497,10 +498,41 @@
} catch (NullPointerException e) {}
}
+ @Deprecated @SuppressWarnings("unchecked")
+ public void testIterator() {
+ HashSet<String> hset = new HashSet<String>();
+ hset.addAll(Arrays.asList(TEST_STOP_WORDS));
+
+ assertTrue("in 3.0 version, iterator should be CharArraySetIterator",
+ ((Iterator) CharArraySet.copy(Version.LUCENE_30, hset).iterator()) instanceof CharArraySet.CharArraySetIterator);
+
+ CharArraySet set = CharArraySet.copy(Version.LUCENE_CURRENT, hset);
+ assertFalse("in current version, iterator should not be CharArraySetIterator",
+ ((Iterator) set.iterator()) instanceof CharArraySet.CharArraySetIterator);
+
+ Iterator<String> it = set.stringIterator();
+ assertTrue(it instanceof CharArraySet.CharArraySetIterator);
+ while (it.hasNext()) {
+ // as the set returns String instances, this must work:
+ assertTrue(hset.contains(it.next()));
+ try {
+ it.remove();
+ fail("remove() should not work on CharArraySetIterator");
+ } catch (UnsupportedOperationException uoe) {
+ // pass
+ }
+ }
+ }
+
public void testToString() {
CharArraySet set = CharArraySet.copy(Version.LUCENE_CURRENT, Collections.singleton("test"));
assertEquals("[test]", set.toString());
set.add("test2");
assertTrue(set.toString().contains(", "));
+
+ set = CharArraySet.copy(Version.LUCENE_30, Collections.singleton("test"));
+ assertEquals("[test]", set.toString());
+ set.add("test2");
+ assertTrue(set.toString().contains(", "));
}
}