You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/06/16 09:29:50 UTC

[GitHub] [yunikorn-release] zhuqi-lucas commented on a diff in pull request #148: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH

zhuqi-lucas commented on code in PR #148:
URL: https://github.com/apache/yunikorn-release/pull/148#discussion_r1232015021


##########
tools/build-image.py:
##########
@@ -172,6 +172,8 @@ def build_manifest(manifest, version):
     for arch in architecture:
         image_name = create_image_name(manifest, version, architecture[arch])
         print(" - image:    %s" % image_name)
+        # image_manifest = create_image_name(manifest, version, manifestmap[arch])

Review Comment:
   If we want to remain this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org