You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/09/17 06:54:15 UTC
[GitHub] [incubator-druid] michaelschiff commented on issue #8546: add
support for dogstatsd events in statsd-emitter
michaelschiff commented on issue #8546: add support for dogstatsd events in statsd-emitter
URL: https://github.com/apache/incubator-druid/pull/8546#issuecomment-532087208
Makes sense to me - my only concern is the potential for the if/else block to grow if there are future additions to the StatsDEmitter. I'm not sure there is enough of an obvious pattern to get the abstraction right yet so I'm okay with the if/else block until one emerges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org