[GitHub] [geode] DonalEvans edited a comment on pull request #5223: Revert "GEODE-7458: Adding option in gfsh command "start gateway send…

[GitBox <gi...@apache.org>]

DonalEvans edited a comment on pull request #5223:
URL: https://github.com/apache/geode/pull/5223#issuecomment-641366892


   The reason for this revert is due to internal tests failing with non-empty serial gateway sender queues. While shutting down gateway senders, events are marked as possible duplicates and the queues are not cleared of these events:
   
   `[info 2020/05/27 00:02:35.859 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped  SerialGatewaySender{id=sender_ds_4_to_ds_3,remoteDsId=3,isRunning =false,isPrimary =true}`
   
   `[info 2020/05/27 00:02:37.382 PDT <vm_17_thr_69_peer_4_2_host1_19135> tid=0x8df] Stopped  SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}`
   
   `[info 2020/05/27 00:02:37.432 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.1> tid=0x5f] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking  5  events as possible duplicates`
   
   `[info 2020/05/27 00:02:37.446 PDT <Event Processor for GatewaySender_sender_ds_4_to_ds_1.0> tid=0x5c] SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =true,isPrimary =true} : Marking  11  events as possible duplicates`
   
   `[info 2020/05/27 00:02:37.623 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped  SerialGatewaySender{id=sender_ds_4_to_ds_2,remoteDsId=2,isRunning =false,isPrimary =true}`
   
   `[info 2020/05/27 00:02:39.656 PDT <vm_19_thr_80_peer_4_4_host1_19147> tid=0x705] Stopped  SerialGatewaySender{id=sender_ds_4_to_ds_1,remoteDsId=1,isRunning =false,isPrimary =true}`
   
   Following the above log output, we see 16 events in in the `unprocessedEventMapSize` stat for the gateway sender in question (each sender has two dispatcher threads in this case, so 5 + 11 = 16).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org