You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/29 11:39:39 UTC

[GitHub] [incubator-nuttx] jlaitine opened a new pull request #2776: drivers/net/encx24j600.c: Correct setting of ifstate

jlaitine opened a new pull request #2776:
URL: https://github.com/apache/incubator-nuttx/pull/2776


   The ifstate is already set in
     enc_ifup -> enc_reset -> enc_linkstatus
   
   The ifstate after this call is either ENCSTATE_RUNNING or ENCSTATE_UP
   
   If ifstate is ENCSTATE_RUNNING, it would be wrong to set it to ENCSTATE_UP;
   this would lead to enc_txavail never invoking the driver callback, causing
   very long latencies in sending.
   
   Signed-off-by: Jukka Laitinen <ju...@ssrc.tii.ae>
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2776: drivers/net/encx24j600.c: Correct setting of ifstate

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #2776:
URL: https://github.com/apache/incubator-nuttx/pull/2776


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org