You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/16 15:48:17 UTC

[GitHub] [airflow] griffincosgrove opened a new pull request #13717: Add missing logos for integrations

griffincosgrove opened a new pull request #13717:
URL: https://github.com/apache/airflow/pull/13717


   Added missing logos .png images and updated provider.yaml file to point to the path for the logo image. Currently, there are many logos on the Apache Site that do not have logo images. Closes #13110
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764758413


   Cool. I might even try to incorporate that into the Provider Readme's :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-762409711


   @mik-laj please check again 😃 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13717:
URL: https://github.com/apache/airflow/pull/13717


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-761585268


   @mik-laj think please help me with the review... again 😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-762221494


   One integration still has a checkerboard pattern.
   ![Screenshot 2021-01-18 at 13 29 40](https://user-images.githubusercontent.com/12058428/104915778-6d12a300-5991-11eb-908a-067e4f9541bb.png)
   
   Can you also add a logo for singularity?
   https://sylabs.io/guides/3.7/user-guide/_static/logo.png


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764065387


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-762287362


   yes @mik-laj, I will do that right now 😄 sorry about that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764065387


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-763220218


   @mik-laj replaced the azure file share logo. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-762952186


   One more chessboard left, but this time it was slightly less visible.
   ![Screenshot 2021-01-19 at 17 17 01](https://user-images.githubusercontent.com/12058428/105061855-467c6700-5a7a-11eb-9dfa-d4e37af4d104.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764064403


   Perfect!
   ![Screenshot 2021-01-21 at 01 20 47](https://user-images.githubusercontent.com/12058428/105256899-f212dd80-5b86-11eb-8cad-b9c971b4a568.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764758413


   Cool. I might even try to incorporate that into the Provider Readme's :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764136412


   Thanks for helping with the review! 😀  @mik-laj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-765024523


   Let me know if I can help @potiuk 
   
   thanks for the help lads! Cheers 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13717:
URL: https://github.com/apache/airflow/pull/13717


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764064403


   Perfect!
   ![Screenshot 2021-01-21 at 01 20 47](https://user-images.githubusercontent.com/12058428/105256899-f212dd80-5b86-11eb-8cad-b9c971b4a568.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] griffincosgrove commented on pull request #13717: Add missing logos for integrations

Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13717:
URL: https://github.com/apache/airflow/pull/13717#issuecomment-764136412






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org